From: Hangbin Liu <liuhangbin@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Aditya Dutt <duttaditya18@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
cgroups@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] selftests: make shell scripts POSIX-compliant
Date: Mon, 17 Feb 2025 03:00:40 +0000 [thread overview]
Message-ID: <Z7KmWNNIsXCnhiax@fedora> (raw)
In-Reply-To: <Z7IOR2UNzjy7cQA7@slm.duckdns.org>
On Sun, Feb 16, 2025 at 06:11:51AM -1000, Tejun Heo wrote:
> On Sun, Feb 16, 2025 at 05:32:25PM +0530, Aditya Dutt wrote:
> > Changes include:
> > - Replaced [[ ... ]] with [ ... ]
> > - Replaced == with =
> > - Replaced printf -v with cur=$(printf ...).
> > - Replaced echo -e with printf "%b\n" ...
> >
> > The above mentioned are Bash/GNU extensions and are not part of POSIX.
> > Using shells like dash or non-GNU coreutils may produce errors.
> > They have been replaced with POSIX-compatible alternatives.
>
> Maybe just update them to use /bin/bash instead? There haven't been a lot of
> reports of actual breakges and a lot of existing tests are using /bin/bash
> already.
+1
Hangbin
next prev parent reply other threads:[~2025-02-17 3:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 12:02 [PATCH] selftests: make shell scripts POSIX-compliant Aditya Dutt
2025-02-16 16:11 ` Tejun Heo
2025-02-17 3:00 ` Hangbin Liu [this message]
2025-02-18 20:44 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7KmWNNIsXCnhiax@fedora \
--to=liuhangbin@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=duttaditya18@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).