From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/6] net: phy: improve phy_disable_eee_mode
Date: Mon, 17 Feb 2025 08:54:29 +0000 [thread overview]
Message-ID: <Z7L5RasngmDnZ01o@shell.armlinux.org.uk> (raw)
In-Reply-To: <92164896-38ff-4474-b98b-e83fc05b9509@gmail.com>
On Sun, Feb 16, 2025 at 10:16:34PM +0100, Heiner Kallweit wrote:
> If a mode is to be disabled, remove it from advertising_eee.
> Disabling EEE modes shall be done before calling phy_start(),
> warn if that's not the case.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-17 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 21:14 [PATCH net-next 0/6] net: phy: improve and simplify EEE handling in phylib Heiner Kallweit
2025-02-16 21:15 ` [PATCH net-next 1/6] net: phy: move definition of phy_is_started before phy_disable_eee_mode Heiner Kallweit
2025-02-16 21:56 ` Andrew Lunn
2025-02-17 8:54 ` Russell King (Oracle)
2025-02-16 21:16 ` [PATCH net-next 2/6] net: phy: improve phy_disable_eee_mode Heiner Kallweit
2025-02-16 22:00 ` Andrew Lunn
2025-02-17 8:54 ` Russell King (Oracle) [this message]
2025-02-16 21:17 ` [PATCH net-next 3/6] net: phy: remove disabled EEE modes from advertising_eee in phy_probe Heiner Kallweit
2025-02-16 22:02 ` Andrew Lunn
2025-02-17 8:54 ` Russell King (Oracle)
2025-02-16 21:18 ` [PATCH net-next 4/6] net: phy: c45: Don't silently remove disabled EEE modes any longer when writing advertisement register Heiner Kallweit
2025-02-17 8:55 ` Russell King (Oracle)
2025-02-16 21:19 ` [PATCH net-next 5/6] net: phy: c45: use cached EEE advertisement in genphy_c45_ethtool_get_eee Heiner Kallweit
2025-02-16 22:08 ` Andrew Lunn
2025-02-17 8:55 ` Russell King (Oracle)
2025-02-16 21:20 ` [PATCH net-next 6/6] net: phy: c45: remove local advertisement parameter from genphy_c45_eee_is_active Heiner Kallweit
2025-02-16 22:09 ` Andrew Lunn
2025-02-17 8:55 ` Russell King (Oracle)
2025-02-19 2:20 ` [PATCH net-next 0/6] net: phy: improve and simplify EEE handling in phylib patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7L5RasngmDnZ01o@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).