From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Saeed Mahameed <saeed@kernel.org>
Subject: Re: [PATCH net-next v3 00/12] net: Hold netdev instance lock during ndo operations
Date: Mon, 17 Feb 2025 10:13:22 -0800 [thread overview]
Message-ID: <Z7N8QgXWP-DJU5Yg@mini-arch> (raw)
In-Reply-To: <20250217090818.390e4efa@kernel.org>
On 02/17, Jakub Kicinski wrote:
> On Mon, 17 Feb 2025 07:17:39 -0800 Stanislav Fomichev wrote:
> > Teaming lock ordering is still not correct :-(
>
> Mm, yeah, looks like patch 9. We need to tell lockdep team's netdev
> lock is not the same one as the lower netdev lock. Probably gotta
> add the instance lock to netdev_lockdep_set_classes() after all?
Adding it to netdev_lockdep_set_classes triggers cleanup_net lockdep
warning. Not sure why my lock_set_cmp_fn doesn't help with that, will
try to debug.
prev parent reply other threads:[~2025-02-17 18:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-16 23:32 [PATCH net-next v3 00/12] net: Hold netdev instance lock during ndo operations Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 01/12] net: hold netdev instance lock during ndo_open/ndo_stop Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 02/12] net: hold netdev instance lock during ndo_setup_tc Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 03/12] net: hold netdev instance lock during queue operations Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 04/12] net: hold netdev instance lock during rtnetlink operations Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 05/12] net: hold netdev instance lock during ioctl operations Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 06/12] net: hold netdev instance lock during sysfs operations Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 07/12] net: hold netdev instance lock during ndo_bpf Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 08/12] net: ethtool: try to protect all callback with netdev instance lock Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 09/12] net: replace dev_addr_sem " Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 10/12] net: dummy: add dummy shaper API Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 11/12] docs: net: document new locking reality Stanislav Fomichev
2025-02-16 23:32 ` [PATCH net-next v3 12/12] eth: bnxt: remove most dependencies on RTNL Stanislav Fomichev
2025-02-17 15:17 ` [PATCH net-next v3 00/12] net: Hold netdev instance lock during ndo operations Stanislav Fomichev
2025-02-17 17:08 ` Jakub Kicinski
2025-02-17 18:13 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7N8QgXWP-DJU5Yg@mini-arch \
--to=stfomichev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).