Re: [PATCH net-next v3 3/4] selftests: drv-net: store addresses in dict indexed by ipver

[Stanislav Fomichev <stfomichev@gmail.com>]

On 02/17, Willem de Bruijn wrote:
> Jakub Kicinski wrote:
> > Looks like more and more tests want to iterate over IP version,
> > run the same test over ipv4 and ipv6. The current naming of
> > members in the env class makes it a bit awkward, we have
> > separate members for ipv4 and ipv6 parameters.
> > 
> > Store the parameters inside dicts, so that tests can easily
> > index them with ip version.
> > 
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> > +++ b/tools/testing/selftests/drivers/net/ping.py
> > @@ -8,17 +8,17 @@ from lib.py import bkg, cmd, wait_port_listen, rand_port
> >  
> >  
> >  def test_v4(cfg) -> None:
> > -    cfg.require_v4()
> > +    cfg.require_ipver("4")
> >  
> > -    cmd(f"ping -c 1 -W0.5 {cfg.remote_v4}")
> > -    cmd(f"ping -c 1 -W0.5 {cfg.v4}", host=cfg.remote)
> > +    cmd(f"ping -c 1 -W0.5 {cfg.remote_addr_v["4"]}")
> > +    cmd(f"ping -c 1 -W0.5 {cfg.addr_v["4"]}", host=cfg.remote)
> 
> Here and below, intended to use single quote around constant?

Let's kick it off the testing queue as well..

# overriding timeout to 90
# selftests: drivers/net: ping.py
#   File "/home/virtme/testing-18/tools/testing/selftests/drivers/net/./ping.py", line 13
#     cmd(f"ping -c 1 -W0.5 {cfg.remote_addr_v["4"]}")
#                                               ^
# SyntaxError: f-string: unmatched '['

---
pw-bot: cr