From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: "Dimitri Fedrau" <dima.fedrau@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Gregor Herburger" <gregor.herburger@ew.tq-group.com>,
"Stefan Eichenberger" <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: phy: marvell-88q2xxx: align defines
Date: Tue, 18 Feb 2025 16:00:42 +0000 [thread overview]
Message-ID: <Z7SuqnfPJD-qQG-c@shell.armlinux.org.uk> (raw)
In-Reply-To: <rfcr7sva7vs5vzfncbtrxcaa7ddosnabxu5xhuqsdspbdxwfrg@scl4wgu3m32n>
On Tue, Feb 18, 2025 at 12:54:29PM +0100, Marek Behún wrote:
> > +#define MDIO_MMD_AN_MV_STAT 32769
>
> Why the hell are register addresses in this driver in decimal?
Shocker - some documentation gives driver addresses for PHYs in
decimal.
It then becomes a pain to have to manually translate back and
forth between hex and decimal if one is reading the driver code and
referring back to the documentation.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-02-18 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 16:32 [PATCH net-next 0/3] net: phy: marvell-88q2xxx: cleanup Dimitri Fedrau
2025-02-14 16:32 ` [PATCH net-next 1/3] net: phy: marvell-88q2xxx: align defines Dimitri Fedrau
2025-02-14 17:52 ` Niklas Söderlund
2025-02-18 11:54 ` Marek Behún
2025-02-18 14:12 ` Andrew Lunn
2025-02-18 14:31 ` Marek Behún
2025-02-18 16:00 ` Russell King (Oracle) [this message]
2025-02-18 18:13 ` Dimitri Fedrau
2025-02-14 16:32 ` [PATCH net-next 2/3] net: phy: marvell-88q2xxx: order includes alphabetically Dimitri Fedrau
2025-02-14 17:53 ` Niklas Söderlund
2025-02-14 16:32 ` [PATCH net-next 3/3] net: phy: marvell-88q2xxx: enable temperature sensor in mv88q2xxx_config_init Dimitri Fedrau
2025-02-14 17:59 ` Niklas Söderlund
2025-02-14 19:45 ` Dimitri Fedrau
2025-02-20 15:37 ` Niklas Söderlund
2025-02-14 18:06 ` Andrew Lunn
2025-02-15 7:13 ` Dimitri Fedrau
2025-02-18 12:50 ` [PATCH net-next 0/3] net: phy: marvell-88q2xxx: cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7SuqnfPJD-qQG-c@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dima.fedrau@gmail.com \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=gregor.herburger@ew.tq-group.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).