* Re: [PATCH net-next] net: phy: remove unused feature array declarations
2025-02-19 20:15 [PATCH net-next] net: phy: remove unused feature array declarations Heiner Kallweit
@ 2025-02-20 8:56 ` Michal Swiatkowski
2025-02-20 10:59 ` Mateusz Polchlopek
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Michal Swiatkowski @ 2025-02-20 8:56 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Andrew Lunn, Russell King - ARM Linux, Jakub Kicinski,
Paolo Abeni, David Miller, Eric Dumazet, netdev@vger.kernel.org
On Wed, Feb 19, 2025 at 09:15:05PM +0100, Heiner Kallweit wrote:
> After 12d5151be010 ("net: phy: remove leftovers from switch to linkmode
> bitmaps") the following declarations are unused and can be removed too.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> include/linux/phy.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3076b4caa..e36eb247c 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -37,10 +37,7 @@ extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_basic_t1_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_basic_t1s_p2mp_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_gbit_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_gbit_fibre_features) __ro_after_init;
> -extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_gbit_all_ports_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_10gbit_features) __ro_after_init;
> -extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_10gbit_fec_features) __ro_after_init;
> -extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_10gbit_full_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_eee_cap1_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_eee_cap2_features) __ro_after_init;
>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> --
> 2.48.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net: phy: remove unused feature array declarations
2025-02-19 20:15 [PATCH net-next] net: phy: remove unused feature array declarations Heiner Kallweit
2025-02-20 8:56 ` Michal Swiatkowski
@ 2025-02-20 10:59 ` Mateusz Polchlopek
2025-02-20 11:32 ` Russell King (Oracle)
2025-02-21 2:33 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Mateusz Polchlopek @ 2025-02-20 10:59 UTC (permalink / raw)
To: Heiner Kallweit, Andrew Lunn, Russell King - ARM Linux,
Jakub Kicinski, Paolo Abeni, David Miller, Eric Dumazet
Cc: netdev@vger.kernel.org
On 2/19/2025 9:15 PM, Heiner Kallweit wrote:
> After 12d5151be010 ("net: phy: remove leftovers from switch to linkmode
> bitmaps") the following declarations are unused and can be removed too.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> include/linux/phy.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3076b4caa..e36eb247c 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -37,10 +37,7 @@ extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_basic_t1_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_basic_t1s_p2mp_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_gbit_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_gbit_fibre_features) __ro_after_init;
> -extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_gbit_all_ports_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_10gbit_features) __ro_after_init;
> -extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_10gbit_fec_features) __ro_after_init;
> -extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_10gbit_full_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_eee_cap1_features) __ro_after_init;
> extern __ETHTOOL_DECLARE_LINK_MODE_MASK(phy_eee_cap2_features) __ro_after_init;
>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net: phy: remove unused feature array declarations
2025-02-19 20:15 [PATCH net-next] net: phy: remove unused feature array declarations Heiner Kallweit
2025-02-20 8:56 ` Michal Swiatkowski
2025-02-20 10:59 ` Mateusz Polchlopek
@ 2025-02-20 11:32 ` Russell King (Oracle)
2025-02-21 2:33 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Russell King (Oracle) @ 2025-02-20 11:32 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Andrew Lunn, Jakub Kicinski, Paolo Abeni, David Miller,
Eric Dumazet, netdev@vger.kernel.org
On Wed, Feb 19, 2025 at 09:15:05PM +0100, Heiner Kallweit wrote:
> After 12d5151be010 ("net: phy: remove leftovers from switch to linkmode
> bitmaps") the following declarations are unused and can be removed too.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net: phy: remove unused feature array declarations
2025-02-19 20:15 [PATCH net-next] net: phy: remove unused feature array declarations Heiner Kallweit
` (2 preceding siblings ...)
2025-02-20 11:32 ` Russell King (Oracle)
@ 2025-02-21 2:33 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-21 2:33 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: andrew, linux, kuba, pabeni, davem, edumazet, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 19 Feb 2025 21:15:05 +0100 you wrote:
> After 12d5151be010 ("net: phy: remove leftovers from switch to linkmode
> bitmaps") the following declarations are unused and can be removed too.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> include/linux/phy.h | 3 ---
> 1 file changed, 3 deletions(-)
Here is the summary with links:
- [net-next] net: phy: remove unused feature array declarations
https://git.kernel.org/netdev/net-next/c/bb3bb6c92e57
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread