From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Simon Horman <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()
Date: Thu, 20 Feb 2025 14:15:54 +0100 [thread overview]
Message-ID: <Z7crCkz1gV6Wz14B@boxer> (raw)
In-Reply-To: <556b48d9-f502-4b02-9131-fbb13cd111a6@6wind.com>
On Thu, Feb 20, 2025 at 02:02:05PM +0100, Nicolas Dichtel wrote:
> Le 20/02/2025 à 11:54, Simon Horman a écrit :
> > On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
> >> This function is not used anymore.
> >>
> >> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
Hi, Fixes tag is redundant as this is -next material.
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > I guess the churn isn't worth it, but it seems to me that
> > __skb_flow_get_ports could be renamed skb_flow_get_ports.
> >
> Right. I can send a follow-up patch.
>
>
>
prev parent reply other threads:[~2025-02-20 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 14:37 [PATCH net-next] skbuff: kill skb_flow_get_ports() Nicolas Dichtel
2025-02-20 10:54 ` Simon Horman
2025-02-20 13:02 ` Nicolas Dichtel
2025-02-20 13:15 ` Maciej Fijalkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7crCkz1gV6Wz14B@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).