From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36BFB1F8BBC for ; Thu, 20 Feb 2025 13:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.16 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740057376; cv=fail; b=S/FONYSGzMV7N2AgxpB0EQDoEp72eUWKJaI2pMn+KGAHUsi9JBGHoAgqKj5+j97p9Ax++GVnp/GtgoKL/zIzNlhUeit6IlsiEuQiXYLqkQN4EfBHPrpnA4d44V6QiODVpGS7L9jSGMh79qSAVoMGJGmFJz/+8X7zdJokdRGAuI8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740057376; c=relaxed/simple; bh=Fz0KHgNoZrd8Z4YJVlIPRTJsmd2B3/dG/7epit+gsYU=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=fR5Sz7C8peX+KO8egcxCXKMNDLjgpOwVgDSpfYSScbP3QH/TiV9fnn37S2o3WpiHZF5ZWL8ZxXRQWu8FZJbH0Ho17H6R8AtNj8wEvjHXG9i/J2SpMAhqVhmN6wOOdNo+VyL5RT3PqnxMyWXWT0pLt8rMoQUfHXbE96J+jqyEabo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=mw15v1+6; arc=fail smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="mw15v1+6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740057374; x=1771593374; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Fz0KHgNoZrd8Z4YJVlIPRTJsmd2B3/dG/7epit+gsYU=; b=mw15v1+6/vrS55oaBcYyj2+J7esJGFUv9ferFRxp3utz1mtt0aM45k6F /fTjdCLb3HT2WMyuHx8PHws/UIFLaQ9tWLkH9l+wrX1JF0iyABMGpqC5u pVQ3FZTvEwKAMKpODQu2HIHh/InTJmbns/buuu9TgQDYkqEqg4k+d0GtB f+ptwTL0g4AzJph+xblLm6rbRP10gHU6ohu/XW1SVYTvQqL4O1emOHrt9 FIEv2xQgvQwEkcEH6GpDo+a0lY75qZirwUWuf/mJSsJ/YvMSZbRPC0nqn gCknO15lQI2hfMnQxZSNd+irbxwAk65jOwkYEgByXHt1tCUGjy8KGOIws g==; X-CSE-ConnectionGUID: zQbIqWNVSU+aEPomJwVEgg== X-CSE-MsgGUID: X1Y7qccfSAmgvJJWViacgA== X-IronPort-AV: E=McAfee;i="6700,10204,11351"; a="28431166" X-IronPort-AV: E=Sophos;i="6.13,301,1732608000"; d="scan'208";a="28431166" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2025 05:16:12 -0800 X-CSE-ConnectionGUID: Nu/gvYCgRMawOb24OPn1GQ== X-CSE-MsgGUID: xCIaxdmuQU6QW7UuHVYr5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,301,1732608000"; d="scan'208";a="138237075" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Feb 2025 05:16:12 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 20 Feb 2025 05:16:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 20 Feb 2025 05:16:11 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 20 Feb 2025 05:16:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lm2u7xE+ZV45kFMkO+46ZAz+7DkngP9sYsaRgjaIF4QEhrI/E0WmBH6hCEuk7VQPzx8a2XM3U/NLJAiadDUSiGzwHlWPyo3mTzOr2fYAKsE4MWX7vwoWdqZXc8DY5pko6y2d/Llx+/YvfvZWpRrANGkL7z2F0jT8kDfPIhgTRlTtj0x3MjcS3Y/9obueweOWBAS11QN/d8pKPkZ2GbpP9v4cyxxaV1MBlxEGBD8JWvuOmEFeGwklPYZJP8mZgNW5b61FxoZcp1L9ig96zS2YJxYKuFjUovpGTNI+B6dBYRLp3LCs9jwiRDYrRFRItou+BSZ65/qa/WZjQm3hUnFNkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=10wX0w/MPqQK2JlzH0uwIRw9PAECVHPFJCj7yOPgaYs=; b=re/YdwwW92NRgTpmCaHPjrMDwAsCBDb6SHtXcWT7oidzbOsY3KXNjl/DXXX09w+aAAAj/HMqo7JhRSkh3p0uQS09d2QkfiRMd7Fs2Ka3NQudpZXIBgk/ilCI6Y1G7p9kqskDTy7VpAkdPwELBMg96jLmAo3orD+/imBB3IefhLKePHCwXnUXE9e8VJkAddzJWU+Ery4NpZjM8Mqybqm8GQXXPwRLlDC8Q1DkqKJdzJeF4OukayqHgLcWlJnHuwfFzK0T/b7GsjGNegzIT9+/Sok4zyz8D7p0Bj3c4OxMn0tI/GAulZSHd7pJbukOzpYghQpuYnWoRvohu1PUxdqgvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) by IA1PR11MB6243.namprd11.prod.outlook.com (2603:10b6:208:3e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.15; Thu, 20 Feb 2025 13:16:08 +0000 Received: from DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::d19:56fe:5841:77ca]) by DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::d19:56fe:5841:77ca%3]) with mapi id 15.20.8466.013; Thu, 20 Feb 2025 13:16:06 +0000 Date: Thu, 20 Feb 2025 14:15:54 +0100 From: Maciej Fijalkowski To: Nicolas Dichtel CC: Simon Horman , "David S. Miller" , Jakub Kicinski , Paolo Abeni , "Eric Dumazet" , Subject: Re: [PATCH net-next] skbuff: kill skb_flow_get_ports() Message-ID: References: <20250218143717.3580605-1-nicolas.dichtel@6wind.com> <20250220105419.GT1615191@kernel.org> <556b48d9-f502-4b02-9131-fbb13cd111a6@6wind.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <556b48d9-f502-4b02-9131-fbb13cd111a6@6wind.com> X-ClientProxiedBy: MI1P293CA0005.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:2::12) To DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6117:EE_|IA1PR11MB6243:EE_ X-MS-Office365-Filtering-Correlation-Id: c30fa8f1-9d6e-4c04-751f-08dd51b0bbe6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?n7f/fXgSp0qRsAUGvHt5v2mHIo0osGprgX2vnfYOAfDts7vKSryjFQ2nSj?= =?iso-8859-1?Q?/AugmX0PPFyHpeON9ZmBJngxlqRdYm4879wKUzVv06gveobQ3DDsKlwEs1?= =?iso-8859-1?Q?SEiLlEC26T6gXxJPDjTNzw8ndWrg0yiOtXa2+kWdUHdudFeCz6Li4VK7vb?= =?iso-8859-1?Q?4OET+JkURBVaBhhulbcf5VIn1OnJf9c0I6fCUXsItM+ZQxSXqgPO1WfTo3?= =?iso-8859-1?Q?QmT7OudSc7pSJ254hNgXt0XPpV4KC2hFEVmdEuWW2hpT7Gx1QazQ1uwN5d?= =?iso-8859-1?Q?N6wOowVWJmFgZ9BRipCnVU1zUwyqC5Azu+26Vy5kNRd/KsTCrpEFvMRBBb?= =?iso-8859-1?Q?gGUHTi192CptB/SmjIVEq5Ip313lBoH8PO87xa4dm/eZbjHVSB5DjDL+Hh?= =?iso-8859-1?Q?DW7wx70ccQYL7+r3fvDp0qRtZDmPAHwvL+nlAf9YdU1lT/1xgCkJWOdx4u?= =?iso-8859-1?Q?OuBmn8RRuyeqI3q1s3GwSdY4qeiRwWs0b6WXv2HvCxKACPTTu2h5bYYClS?= =?iso-8859-1?Q?Ggnt02ynHj2SSJqtvfaHO6T4/hvGfUSi/XVWRrEoHh9ReNxfvkb0+I/75H?= =?iso-8859-1?Q?YzGOAk+eNkBWkRN3ajIIH1737wsXEYBSQ4ynORIg06yk4kdsVsbR/x6dZn?= =?iso-8859-1?Q?LcemRGSCNAMG5Rmoez/K115raqgubNkcDqte97WKJzcGkNtkH9NMnAZzc1?= =?iso-8859-1?Q?CHXAUicKYg+ovoZpp3VZwA5aOoHtht1jsHlmY6qlHOhe3tjZIWKPNhda7P?= =?iso-8859-1?Q?oyTSXAnxZOM8IgQbwPbScNCKSW9tX1J1lihg0OdsF2Rt9ckV+l17dkbUT5?= =?iso-8859-1?Q?z4HI6nmhDYtW7bl8TYmd80ff9Q6MSFrGrYC1B8QMJi6Mm7QkmnwUB4uYIl?= =?iso-8859-1?Q?pIt6DN0JNgaesmABqWzMwSk6js1yatnFdqTiQS4ho8lWUwARqV8i8PW1R0?= =?iso-8859-1?Q?+DoINsG3k4wgD44S1C/VaABHea7L7kT91abL6yTanQ7mjSrzKsK4JGyEfO?= =?iso-8859-1?Q?P35Rrc2h6AT6Vzry0xv99g4tZb5jqMDlnyoEKFHCaeCa1JhTNZjcHV6kgA?= =?iso-8859-1?Q?BOrzCEb2b930MNZRklvDUtgMDBX4u1Z2ByExyas2xx93CkKlPYCbLkrhNs?= =?iso-8859-1?Q?69WYxWSXWcZMJVoJPm9ywCWz81ITEOF7pjzxJQhNwCK/FDyi8PU3CwM05P?= =?iso-8859-1?Q?kSMKv8o9vqR3FX2G42WDO76mrOfemPFe9Roz95vUBoc7wfgoUtIwPpNQik?= =?iso-8859-1?Q?NvLMKLcTCnUdt/MRNc9+j12pliL5mcogA5UM/L2poAonP6HD9Itnn2ORHE?= =?iso-8859-1?Q?tiHj2UOkklaAAe6ww0Z+03X+xk/Y9Pbw7espSuS7e8eAgZwMAJoyqOUHRK?= =?iso-8859-1?Q?mVSFGzAKSRTLap5DS50TbFJ3lF9PDMds5EJ2/NdgrhJ/7xTThEhnScv1UB?= =?iso-8859-1?Q?btret0koevOckbPb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6117.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?PuQaaA0HDI4Z4TtbOhBzFASSzVv6Ias8wCie/osC7NPMdxzsmjhQslpjYI?= =?iso-8859-1?Q?lexvubZY8AQ3TTfxiqeOpWOumLsNVdFqq0s2IR1tVP68EZoeo5fXAc0xl4?= =?iso-8859-1?Q?7omFxxwCsGQOtifFFO0+3FBRJ7xpmhhcV2PGSykgsD4DI5gwn9hScW0Rct?= =?iso-8859-1?Q?nxdZXdYyIS8DIz3l4eNTEYXStZvxQNEmQIu2QOA5KmQVBdP/KFM6fc8JFU?= =?iso-8859-1?Q?sgQDaoxzRU/qFXqADcPLZ4J/0UNZMyjq/vZ9t47juieYW+fKDVVqKTQ17u?= =?iso-8859-1?Q?o+YWAeOsofSo8qwAKaT1jiTty0l/3sJKhrhtz0s2gCmK0hhVIt6ssav5mF?= =?iso-8859-1?Q?ZfU7Bsh8QLZaF94MbySPF4lZOwDfXGLe0zen6cgolj7pi1AE0V1Z7iJtf+?= =?iso-8859-1?Q?z+oMk1xmf5HBOrtmAk3liljuYPZ6LTiK9gsR//LpFRPY4nriYwM00TUMfW?= =?iso-8859-1?Q?q7xxTMbUPjnHs4XPW0EsK2To5LwWtsA48nrnuyodXFB/EMXaqr8uee1/DU?= =?iso-8859-1?Q?FVQaVF3Na3MY6QeBb69bOrtFpXukhaKoAiI+aCe0PrNxtEW2pUGC85zJv4?= =?iso-8859-1?Q?KZR6RWvvbUQPKFxZsFQKjCHlyVrqmdVeZDCd3II8cEyxat9V+JM7Md9lCp?= =?iso-8859-1?Q?oanQRQgDP1GwXTjaile6JC+RtoX/3p46CwjeH1hbxqTCEM2aIv0xy4SjUP?= =?iso-8859-1?Q?kAd/9SQC4+MRmw4Cmem0U4ADfzUBIFURuAHdoichKEkhEVBGntU0jrd/YA?= =?iso-8859-1?Q?RyYixouX9itE/wXdY1+IIYzwiSZ+dS0rtFOWprSDePzHyee9uC3P6trP2p?= =?iso-8859-1?Q?rpMRfGpGvoKyydsQoP/hjXvFL3+ZoKQzcSdQTtvqMFcavRiaResdTYnC+x?= =?iso-8859-1?Q?0JatYDGYF2aq8tgnv/lPXYE3m7n59hTHfFCqDz9ITbWzh0tUwmn/A5Qrgx?= =?iso-8859-1?Q?7yUkd3zbo18tfbboh0CK8FNs5l8dUMy5h6EZquscVvC4k4hmgcb+xjbnQ8?= =?iso-8859-1?Q?E1tKR3SosHd1uNHsEaxstNwT7eU5OWUMv5rVa2dliwTLZUuYCp3Guy3c0k?= =?iso-8859-1?Q?t/Z2JgUGjyGFyG0tIBwd7BkEod1iRtA3aLddVhIXZXIG1toOATjSH0ZdxP?= =?iso-8859-1?Q?SXRzhxWVxW1hwPuQZ/htrnuMuYW+Q4JurBmDVGB/TI3QtYrXb2XIeInCvr?= =?iso-8859-1?Q?iLQOGVf3UTND0RQNrbRmVnjwmunOO3AIHY/ylRGnW0NjZH+SBJFSFiDd0L?= =?iso-8859-1?Q?fWkeVU5o8BpvTpGrqXbRjm9LagyU99qbPFe4u+bYvkOUG97a3JZigwfTn+?= =?iso-8859-1?Q?G04D2AdputqnxjEWA6/4s+A6dOLDojd4Mg9mtGULBeqxAyPCWh0mIzt7KU?= =?iso-8859-1?Q?JeoWQram6XZ3CvJ0byIBchJ/Y/JdJFdcsOF1RCFAkmAzioAK+rdJQKxcOH?= =?iso-8859-1?Q?it9sgQWExfs1TdBh1N3g70RuEyNg6Q5As2k1fy/ETt+Z1/Q9wnyjDdWDXL?= =?iso-8859-1?Q?KHCqlwAe0rj8ylS3YbMNX6v/8jb8TnTkdv0oS++85X0scn8y21ZhxaGRYH?= =?iso-8859-1?Q?Cw0pg/rUa23Tby8kUwRqTtx9HasfJUdrc4F2Zhj7FZysggpGZhxVvEBwRe?= =?iso-8859-1?Q?HVjSr/dhOgI2/Mk3LNJeNmOvzBV1pHW/T29rPvif8Nn2wx+QEUi3/0aw?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c30fa8f1-9d6e-4c04-751f-08dd51b0bbe6 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 13:16:06.6317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Ylhbm78fe9HD1ixPQZc2cq2h8a1j6pkPyNFu+U4KfJDugOSYp+DC/WomCSdX+KTZAZDZ/wXWRPWvWQEw7F8bL2vsakdqymcE3hkeSBaQjk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6243 X-OriginatorOrg: intel.com On Thu, Feb 20, 2025 at 02:02:05PM +0100, Nicolas Dichtel wrote: > Le 20/02/2025 à 11:54, Simon Horman a écrit : > > On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote: > >> This function is not used anymore. > >> > >> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff") Hi, Fixes tag is redundant as this is -next material. > >> Signed-off-by: Nicolas Dichtel > > > > Reviewed-by: Simon Horman > > > > I guess the churn isn't worth it, but it seems to me that > > __skb_flow_get_ports could be renamed skb_flow_get_ports. > > > Right. I can send a follow-up patch. > > >