From: Sabrina Dubroca <sd@queasysnail.net>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
Saeed Mahameed <saeed@kernel.org>
Subject: Re: [PATCH net-next v5 03/12] net: hold netdev instance lock during queue operations
Date: Thu, 20 Feb 2025 16:11:16 +0100 [thread overview]
Message-ID: <Z7dGFLSom9mnWFdB@hog> (raw)
In-Reply-To: <20250219202719.957100-4-sdf@fomichev.me>
2025-02-19, 12:27:10 -0800, Stanislav Fomichev wrote:
> diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
> index 533e659b15b3..cf9bd08d04b2 100644
> --- a/drivers/net/ethernet/google/gve/gve_main.c
> +++ b/drivers/net/ethernet/google/gve/gve_main.c
> @@ -1886,7 +1886,7 @@ static void gve_turndown(struct gve_priv *priv)
> netif_queue_set_napi(priv->dev, idx,
> NETDEV_QUEUE_TYPE_TX, NULL);
>
> - napi_disable(&block->napi);
> + napi_disable_locked(&block->napi);
I don't think all the codepaths that can lead to gve_turndown have the
required netdev_lock():
gve_resume -> gve_reset_recovery -> gve_turndown
gve_user_reset -> gve_reset -> gve_reset_recovery
(and nit:) There's also a few places in the series (bnxt, ethtool
calling __netdev_update_features) where the lockdep
annotation/_locked() variant gets introduced before the patch adding
the corresponding lock.
--
Sabrina
next prev parent reply other threads:[~2025-02-20 15:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 20:27 [PATCH net-next v5 00/12] net: Hold netdev instance lock during ndo operations Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 01/12] net: hold netdev instance lock during ndo_open/ndo_stop Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 02/12] net: hold netdev instance lock during ndo_setup_tc Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 03/12] net: hold netdev instance lock during queue operations Stanislav Fomichev
2025-02-20 15:11 ` Sabrina Dubroca [this message]
2025-02-20 17:00 ` Stanislav Fomichev
2025-02-21 16:18 ` Sabrina Dubroca
2025-02-21 17:16 ` Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 04/12] net: hold netdev instance lock during rtnetlink operations Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 05/12] net: hold netdev instance lock during ioctl operations Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 06/12] net: hold netdev instance lock during sysfs operations Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 07/12] net: hold netdev instance lock during ndo_bpf Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 08/12] net: ethtool: try to protect all callback with netdev instance lock Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 09/12] net: replace dev_addr_sem " Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 10/12] net: add option to request " Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 11/12] docs: net: document new locking reality Stanislav Fomichev
2025-02-19 20:27 ` [PATCH net-next v5 12/12] eth: bnxt: remove most dependencies on RTNL Stanislav Fomichev
2025-02-19 21:28 ` Michael Chan
2025-02-19 23:16 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7dGFLSom9mnWFdB@hog \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox