From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
stfomichev@gmail.com, petrm@nvidia.com
Subject: Re: [PATCH net-next v2 3/7] selftests: drv-net: add missing new line in xdp_helper
Date: Thu, 20 Feb 2025 12:48:56 -0500 [thread overview]
Message-ID: <Z7drCEsGAQz6cxjf@LQ3V64L9R2> (raw)
In-Reply-To: <20250219234956.520599-4-kuba@kernel.org>
On Wed, Feb 19, 2025 at 03:49:52PM -0800, Jakub Kicinski wrote:
> Kurt and Joe report missing new line at the end of Usage.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> v2: new
> ---
> tools/testing/selftests/drivers/net/xdp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/net/xdp_helper.c b/tools/testing/selftests/drivers/net/xdp_helper.c
> index cf06a88b830b..80f86c2fe1a5 100644
> --- a/tools/testing/selftests/drivers/net/xdp_helper.c
> +++ b/tools/testing/selftests/drivers/net/xdp_helper.c
> @@ -35,7 +35,7 @@ int main(int argc, char **argv)
> char byte;
>
> if (argc != 3) {
> - fprintf(stderr, "Usage: %s ifindex queue_id", argv[0]);
> + fprintf(stderr, "Usage: %s ifindex queue_id\n", argv[0]);
> return 1;
> }
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-02-20 17:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 23:49 [PATCH net-next v2 0/7] selftests: drv-net: improve the queue test for XSK Jakub Kicinski
2025-02-19 23:49 ` [PATCH net-next v2 1/7] selftests: drv-net: add a warning for bkg + shell + terminate Jakub Kicinski
2025-02-20 17:27 ` Stanislav Fomichev
2025-02-20 17:48 ` Joe Damato
2025-02-20 19:31 ` Joe Damato
2025-02-20 21:10 ` Jakub Kicinski
2025-02-20 22:53 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 2/7] selftests: drv-net: use cfg.rpath() in netlink xsk attr test Jakub Kicinski
2025-02-19 23:49 ` [PATCH net-next v2 3/7] selftests: drv-net: add missing new line in xdp_helper Jakub Kicinski
2025-02-20 7:26 ` Kurt Kanzenbach
2025-02-20 17:48 ` Joe Damato [this message]
2025-02-19 23:49 ` [PATCH net-next v2 4/7] selftests: drv-net: probe for AF_XDP sockets more explicitly Jakub Kicinski
2025-02-20 17:27 ` Stanislav Fomichev
2025-02-20 18:16 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 5/7] selftests: drv-net: add a way to wait for a local process Jakub Kicinski
2025-02-20 17:29 ` Stanislav Fomichev
2025-02-20 19:28 ` Joe Damato
2025-02-19 23:49 ` [PATCH net-next v2 6/7] selftests: drv-net: improve the use of ksft helpers in XSK queue test Jakub Kicinski
2025-02-20 7:31 ` Kurt Kanzenbach
2025-02-19 23:49 ` [PATCH net-next v2 7/7] selftests: drv-net: rename queues check_xdp to check_xsk Jakub Kicinski
2025-02-20 19:35 ` [PATCH net-next v2 0/7] selftests: drv-net: improve the queue test for XSK Joe Damato
2025-02-21 2:17 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7drCEsGAQz6cxjf@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox