From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CCB23D984 for ; Sun, 23 Feb 2025 11:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740310841; cv=none; b=dea0x2GPzG/qbi+hLenmCWoITYWfjy6gmfBoswnm1jDUo0wEeqwzvf9bqPmI65JrWhPiC97KhZaqx1FluKtZOL0dXWlh2mPEY60xfUjUTDpfUQcGRbmbw3YGnqJzD1pIdVt31IpTZDAmYeBRYDJ2EEzx5c+uPcUrjyxhp7jnEQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740310841; c=relaxed/simple; bh=ublvBogodnw8msiGU0MgAbXyEzVxq+O95rFu42etUUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=obcLbRU2g1lhVf4qH8FAo3XmRpPNyz8GCQU9okQROBq3D55eeD51MDHmwSYr95hbeI7Oj2Z0ojdH7o3qw+ogUceUgqrqqkkHANvC9tZhhIE5dAoYERF6lWV0ALZ06hhh3NIM9hfAzSSSS8Bwq+wsfAnR0/w/FcZDiWBiFhstOIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=FIAYQaLj; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="FIAYQaLj" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NgBWyniUF/OIJUlHK2K7BrSpGMn7fltVSGcDSX0c/GY=; b=FIAYQaLjg14eiUynjgEta+jcV6 ncxKfDn7c5vT5jHvjLpNKBzxSR2LuYPX5WP+/lc2+LAqfFPlpt7Qs4BD2AwPzTyEXn/UpwVRDUZB3 /MRe/uM63FmDNZdf5bVjldLKiOO1nIkxngExo/E4aGlwssrsJ5oRcJc73KZviwtFnlzarbFIpvB7p 6AltjBZbgtnoHheNlX2hixabQQ3/c4pvYzicE+QOJ/cthdCVawlAKTjsC0HSNUB8kgr1FexuYxrVE tvEw6B+danCezT63cQdu8rdfSQ/T23RYTBcHT9sAi6W1Hp8G/z8cU5awaH0e5pWTXn66r9afrOw1U y05zJiOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54522) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tmALM-0002rw-1T; Sun, 23 Feb 2025 11:40:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tmALG-0003y2-2N; Sun, 23 Feb 2025 11:40:14 +0000 Date: Sun, 23 Feb 2025 11:40:14 +0000 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit , Jakub Kicinski , Joe Perches Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Drew Fustini , Eric Dumazet , Fu Wei , Guo Ren , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next 0/2] net: stmmac: thead: clean up clock rate setting Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Adding Joe Perches. On Fri, Feb 21, 2025 at 02:15:17PM +0000, Russell King (Oracle) wrote: > Hi, > > This series cleans up the thead clock rate setting to use the > rgmii_clock() helper function added to phylib. > > The first patch switches over to using the rgmii_clock() helper, > and the second patch cleans up the verification that the desired > clock rate is achievable, allowing the private clock rate > definitions to be removed. > > drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 28 ++++++++--------------- > 1 file changed, 9 insertions(+), 19 deletions(-) I've been investigating why the NIPA bot complains about maintainers not being Cc'd, such as for patch 1 of this series: https://netdev.bots.linux.dev/static/nipa/936447/13985595/cc_maintainers/stdout I think this is a bug in either get_maintainers.pl or the NIPA bot. On the bare patch without any Cc: header added: $ scripts/get_maintainer.pl 0001-net-stmmac-thead-use-rgmii_clock-for-RGMII-clock-rat.patch Drew Fustini (maintainer:RISC-V THEAD SoC SUPPORT) Guo Ren (maintainer:RISC-V THEAD SoC SUPPORT) Fu Wei (maintainer:RISC-V THEAD SoC SUPPORT) Andrew Lunn (maintainer:NETWORKING DRIVERS) "David S. Miller" (maintainer:NETWORKING DRIVERS) Eric Dumazet (maintainer:NETWORKING DRIVERS) Jakub Kicinski (maintainer:NETWORKING DRIVERS) Paolo Abeni (maintainer:NETWORKING DRIVERS) Maxime Coquelin (maintainer:ARM/STM32 ARCHITECTURE) Alexandre Torgue (maintainer:ARM/STM32 ARCHITECTURE) linux-riscv@lists.infradead.org (open list:RISC-V THEAD SoC SUPPORT) netdev@vger.kernel.org (open list:STMMAC ETHERNET DRIVER) linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE) linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE) If I add those maintainers to a Cc header in the patch file (as it would be if NIPA runs on the unmodified received email), and then re-run get_maintainer.pl, then: $ scripts/get_maintainer.pl 0001-net-stmmac-thead-use-rgmii_clock-for-RGMII-clock-rat.patch Drew Fustini (maintainer:RISC-V THEAD SoC SUPPORT) Guo Ren (maintainer:RISC-V THEAD SoC SUPPORT) Fu Wei (maintainer:RISC-V THEAD SoC SUPPORT) Andrew Lunn (maintainer:NETWORKING DRIVERS) "David S. Miller" (maintainer:NETWORKING DRIVERS) Eric Dumazet (maintainer:NETWORKING DRIVERS) Jakub Kicinski (maintainer:NETWORKING DRIVERS) Paolo Abeni (maintainer:NETWORKING DRIVERS) Maxime Coquelin (maintainer:ARM/STM32 ARCHITECTURE) Alexandre Torgue (maintainer:ARM/STM32 ARCHITECTURE) Paul Walmsley (supporter:RISC-V ARCHITECTURE:Keyword:riscv) Palmer Dabbelt (supporter:RISC-V ARCHITECTURE:Keyword:riscv) Albert Ou (supporter:RISC-V ARCHITECTURE:Keyword:riscv) linux-riscv@lists.infradead.org (open list:RISC-V THEAD SoC SUPPORT) netdev@vger.kernel.org (open list:STMMAC ETHERNET DRIVER) linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE) linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE) linux-kernel@vger.kernel.org (open list) Note the addition of Paul Walmsley, Palmer Dabbelt and Albert Ou that was not in the original. It seems that K: is fed everything in the file, including all headers. In the second run, the addition of the linux-riscv@lists.infradead.org mailing list in the headers then causes a subseqent run of get_maintainer.pl (and nipa's run of get_maintainer.pl) to then match using K: riscv in the "RISC-V ARCHITECTURE" entry. So, it seems running get_maintainer.pl on an email received from mailing lists without first stripping many of the email headers can lead to false K: matches. This makes NIPA's cc_maintainers test unreliable. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!