From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92CB4163 for ; Sun, 23 Feb 2025 14:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740320987; cv=none; b=KV99JZBckFbkrsqTBQZz/vjVT5YAqqT45A0RlyeG0tChxT3RCB9V5DUk9A8HEPZIEhMmE9Yn//qjx3TlT5dlvkJgqZclodF0vgRxfZKbfDob2SsG/AB5h2DAfmD1s0KcC1z6mvqwd7Dn7M6Y8OwhBN+ww5Y8uiRmulTZg12MFSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740320987; c=relaxed/simple; bh=N9eYfn2zn9bHh7uK3ZU9xbTbkTkqKFJE5iIHBeiZWyw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fwf6HIlHn6hFZ/8s4ZqCCYHX5GsboISwERBHy9TEofOZvZsodKNNpfcRf/2mk32Lx3BeCtMPk8kq89bjElxgj/sBFDf/N5jCMAjNvZdbqZ3T3WKHbMp7HGohfkLN/eAH1IsHOx/Bbergga3rejHbFq7pmiJVT18IMg77OXjp1Kg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=4EeOOFLX; arc=none smtp.client-ip=202.12.124.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="4EeOOFLX" Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 5C7221140141; Sun, 23 Feb 2025 09:29:44 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Sun, 23 Feb 2025 09:29:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1740320984; x=1740407384; bh=WC5+Wt6Y2zwG4QUlmEplEm8BOPI04Pmx396 1hisxzGs=; b=4EeOOFLXdonpqxb2wQ+5ahsvSc8Uol1/fddofg+XpoXMLun41YP N6tozDv+4qxyYUPpYe0THg3X1wWA5YqPR4PAA9zMXpOEiZxIaKEdNeFX4piNipJl kibuPVR4poS9f+G/M91guurJWbvsnwmVW1jwK7v/kV7KGkVW2Ja9wFHjVmhUlj7P FdeTL/5T8+tqT9rmjqKOrTtySPRAhsr+YCHCUtNYIF/mhK64pYd5SkyRa1OvY3Xf /q+zmdZJw2Du1KAAE/vGv3OIOvToGD0IpXxKaIX3xgcPSKQI4BE/FklYJFuuUgWb Wbyh7uHjmAwP7uOzS+KwG81a/tkte4Om5gg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdejiedtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrd horhhgqeenucggtffrrghtthgvrhhnpeejgeejhfffiefggfehveefffetkeevkeduueeh ieeiudelgedtleelteekvdefkeenucffohhmrghinheptghonhhfrdguvghvnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihguohhstghhsehi ughoshgthhdrohhrghdpnhgspghrtghpthhtohepledpmhhouggvpehsmhhtphhouhhtpd hrtghpthhtohepghhnrghulhhtsehrvgguhhgrthdrtghomhdprhgtphhtthhopegurghv vghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepkhhusggrsehkvghrnhgvlh drohhrghdprhgtphhtthhopehprggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthht ohepvgguuhhmrgiivghtsehgohhoghhlvgdrtghomhdprhgtphhtthhopehnvghtuggvvh esvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehhohhrmhhssehkvghrnhgv lhdrohhrghdprhgtphhtthhopegushgrhhgvrhhnsehkvghrnhgvlhdrohhrghdprhgtph htthhopegrnhhtohhnihhosehmrghnuggvlhgsihhtrdgtohhm X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Feb 2025 09:29:43 -0500 (EST) Date: Sun, 23 Feb 2025 16:29:40 +0200 From: Ido Schimmel To: Guillaume Nault Cc: David Miller , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, Simon Horman , David Ahern , Antonio Quartulli Subject: Re: [PATCH net v2 2/2] selftests: Add IPv6 link-local address generation tests for GRE devices. Message-ID: References: <5c40747f9c67a54f8ceba9478924a75755c42b07.1740129498.git.gnault@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c40747f9c67a54f8ceba9478924a75755c42b07.1740129498.git.gnault@redhat.com> On Fri, Feb 21, 2025 at 10:24:10AM +0100, Guillaume Nault wrote: > GRE devices have their special code for IPv6 link-local address > generation that has been the source of several regressions in the past. > > Add selftest to check that all gre, ip6gre, gretap and ip6gretap get an > IPv6 link-link local address in accordance with the > net.ipv6.conf..addr_gen_mode sysctl. > > Signed-off-by: Guillaume Nault There are some helpers from lib.sh that could have been used, but the test is very clean and easy to follow, so: Reviewed-by: Ido Schimmel Tested-by: Ido Schimmel Thanks!