From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2FF21E9B1F for ; Tue, 11 Mar 2025 03:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741664256; cv=none; b=BO9YzVC68SGiif+irVqvKhuGaVEJWkx4TL7htJEAjY2H7O+y90NO/DUuFyLe9p7PApkvq7zmuW3yODRoTVyOYffZJTpQU6csroU9nT++W+c4aNnU4KWiouLibIJkDOoG4d3V+cKFbRGb40Fqd+G52wqCF1goyjZLHlFOVRFwJKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741664256; c=relaxed/simple; bh=WJDiIpzPVyWLH5Cn8j/8u3aIFFtw49GPgJTMCyuAZFc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oImW/PfxL52sgXOQHEMjPzc4ejMvjpYImMoW/fIGU3grOvqZMWr3nPhUUe5I1J+rPoAYl01QCKV50x7lxIebWXajGM3VnCVKglmeYkWEIMJWKFshpYGFaCPvnrzd68Kpql7YeAfGbI+DSYshaKp3NfEeWjjucNUdOJkhjp/RtNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=R7r49EIs; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="R7r49EIs" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2242ac37caeso56765ad.1 for ; Mon, 10 Mar 2025 20:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741664253; x=1742269053; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GKKMXhARfXEwg2PwHrZN99nBi8+39p+oYTJh2YeoKoU=; b=R7r49EIsnN7h/+o3taKGdxwyS6LTzYjaMxZ6eza16XBSC7e6lyvhyA8SxT9yNJwZCL ftWf4Sl5oO02NYlDMk432YfL2hSTBPQg9mxtJIpy+La2kW2lWlCL8Et5hX9ZTbY5FbWn 5Sq8E00Vxm/oi7Y1O2qGbbrOGWyJZ5WwnRcMrUPw4+qXnYmB5if25PpKz1Z+qDBRIX9Z N84QCsK+9ej17pCRz0y0IsncIfkw6T+yfgQBa+kwHPcSoWpYhtPOuItg38bzg4M0X/uW wN4SS73PPN1CbO+P86QekKiH32mdArq9zwiGjDt7sZoeLk97je+nUkNajlz2qVx/DqUG As8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741664253; x=1742269053; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GKKMXhARfXEwg2PwHrZN99nBi8+39p+oYTJh2YeoKoU=; b=lB08qNeMy2QcRIZdpmwQHpD8WC/O+ThSVK8Pxq2k42vPfhZWxaDil3xAdszJY8adyf riCjWTJ8VQtwv4Ed9lUKHTBzsRFMGKxIde3DvydGcJtK92bMkm6UfDCMtqqjr+pKNM0h M5BexnErS60N4KXWB9ppj9U1CdC4AEuRvzNqct3tP6i9oVKSJ++QwwPKb9uZOeoSD11c g0Hote03qsf1IpEeeuwVT9fPRKfMUEyV7fYSa0zK+sp4P5t0nWyoo5hJngNggXVobohF JFCumgI1XLxik5og/qwF5rMzEDiIgsH20GhrxHFrnhoJPslzWy93BhniRFKcuM5DaaUB IDNg== X-Forwarded-Encrypted: i=1; AJvYcCWQhQ4ePBxdcIpOZditutFnmSaSTBsJ20xHO4Dv0f0KxLBdp3BaWsir+pDzD2sDfMH2Sfp0p9k=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu2ONJGnGPIx2tFxvEs9cXtCjTisiVRmJwIXZzFkjxbEjJHu1I mHGhcbWsGA92ds2E/8dV80gnQMg8NbZs65dOsU3w9UKvgZ8pQAModT7rl1gzpQ== X-Gm-Gg: ASbGnctb9JsdxUqkA7EfE9fgvjQuQOGgimtCqaUcyvsTiwdj3tIQIcIt6Kr1WARm18K 2jtEj5FcHmc2ItQRSsU9DBVQweSvpLFQGqkHr5/DTzGei2juuuMcr4s1tzANDt/x8PyQ+9PBVvk DKouEH/Jy9y8GR5SNIyPW4gattbCE6W3pfRx4ylkydI/kfCzoiZ2CS7C+wugzdTFVPMf44Hd+i8 bdd4zSHu0ESafDn4DUYYFSFN6FQOs8fHN2g3j0o+fqHPyarIzI5jgviXi3YtE+Piz7YnNwV/doe XXimveks/8JtU/l+qG9+AuCtJZeEAYSqeIwXCkUNPh01alw5Xusc/x8sOws6g0VaJisX+lRy1T4 Wz2nQYt8= X-Google-Smtp-Source: AGHT+IEK91Z6kXFaIWJCVbtXPxgiAIU5QooJrJa6uX0FbecTFo4b+EzP9+Bxt6J46OcmUjrvYOGJvg== X-Received: by 2002:a17:902:ecc4:b0:224:a93:704d with SMTP id d9443c01a7336-22540e584dbmr6561245ad.2.1741664252755; Mon, 10 Mar 2025 20:37:32 -0700 (PDT) Received: from google.com (57.145.233.35.bc.googleusercontent.com. [35.233.145.57]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ff4e789340sm10752115a91.26.2025.03.10.20.37.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 20:37:32 -0700 (PDT) Date: Tue, 11 Mar 2025 03:37:27 +0000 From: Carlos Llamas To: Li Li Cc: dualli@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, donald.hunter@gmail.com, gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, brauner@kernel.org, surenb@google.com, omosnace@redhat.com, shuah@kernel.org, arnd@arndb.de, masahiroy@kernel.org, bagasdotme@gmail.com, horms@kernel.org, tweek@google.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, selinux@vger.kernel.org, hridya@google.com, smoreland@google.com, ynaffit@google.com, kernel-team@android.com Subject: Re: [PATCH v16 3/3] binder: generic netlink binder_features flag Message-ID: References: <20250303200212.3294679-1-dualli@chromium.org> <20250303200212.3294679-4-dualli@chromium.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303200212.3294679-4-dualli@chromium.org> On Mon, Mar 03, 2025 at 12:02:12PM -0800, Li Li wrote: > From: Li Li > > Add a flag to binder_features to indicate that the generic netlink > feature is available. > > Signed-off-by: Li Li > --- The implementation looks correct. However, the feature you are adding is not "generic_netlink", maybe "transaction_report" or something similar? Future features might use this same interface so lets avoid confusion. Thanks,