From: Kevin Krakauer <krakauer@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
willemb@google.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: bump GRO timeout for gro/setup_veth
Date: Mon, 10 Mar 2025 10:26:37 -0700 [thread overview]
Message-ID: <Z88gzcGu5_WX3je0@google.com> (raw)
In-Reply-To: <20250310110821.385621-1-kuba@kernel.org>
On Mon, Mar 10, 2025 at 12:08:21PM +0100, Jakub Kicinski wrote:
> Commit 51bef03e1a71 ("selftests/net: deflake GRO tests") recently
> switched to NAPI suspension, and lowered the timeout from 1ms to 100us.
> This started causing flakes in netdev-run CI. Let's bump it to 200us.
> In a quick test of a debug kernel I see failures with 100us, with 200us
> in 5 runs I see 2 completely clean runs and 3 with a single retry
> (GRO test will retry up to 5 times).
Thanks for finding and fixing this. And now I know there's CI that can
be checked!
Reviewed-by: Kevin Krakauer <krakauer@google.com>
next prev parent reply other threads:[~2025-03-10 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 11:08 [PATCH net-next] selftests: net: bump GRO timeout for gro/setup_veth Jakub Kicinski
2025-03-10 17:26 ` Kevin Krakauer [this message]
2025-03-12 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z88gzcGu5_WX3je0@google.com \
--to=krakauer@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).