From: Kevin Krakauer <krakauer@google.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] selftests/net: have `gro.sh -t` return a correct exit code
Date: Thu, 27 Feb 2025 13:25:04 -0800 [thread overview]
Message-ID: <Z8DYMBlzcK5sFG-M@google.com> (raw)
In-Reply-To: <67c090bf9db73_37f929294ec@willemb.c.googlers.com.notmuch>
On Thu, Feb 27, 2025 at 11:20:15AM -0500, Willem de Bruijn wrote:
> > ---
> > tools/testing/selftests/net/gro.sh | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh
> > index 02c21ff4ca81..aabd6e5480b8 100755
> > --- a/tools/testing/selftests/net/gro.sh
> > +++ b/tools/testing/selftests/net/gro.sh
> > @@ -100,5 +100,6 @@ trap cleanup EXIT
> > if [[ "${test}" == "all" ]]; then
> > run_all_tests
> > else
> > - run_test "${proto}" "${test}"
> > + exit_code=$(run_test "${proto}" "${test}")
> > + exit $exit_code
> > fi;
>
> This is due to run_test ending with echo ${exit_code}, which itself
> always succeeds. Rather than the actual exit_code of the process it
> ran, right?
>
> It looks a bit odd, but this is always how run_all_tests uses
> run_test.
Yep. I could change this to use exit codes and $? if that's desirable,
but IME using echo to return is fairly common.
next prev parent reply other threads:[~2025-02-27 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 19:27 [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output Kevin Krakauer
2025-02-26 19:27 ` [PATCH v2 1/3] selftests/net: have `gro.sh -t` return a correct exit code Kevin Krakauer
2025-02-27 16:20 ` Willem de Bruijn
2025-02-27 21:25 ` Kevin Krakauer [this message]
2025-02-27 21:31 ` Willem de Bruijn
2025-02-26 19:27 ` [PATCH v2 2/3] selftests/net: only print passing message in GRO tests when tests pass Kevin Krakauer
2025-02-27 16:20 ` Willem de Bruijn
2025-02-26 19:27 ` [PATCH v2 3/3] selftests/net: deflake GRO tests Kevin Krakauer
2025-02-27 16:14 ` Willem de Bruijn
2025-02-27 16:36 ` [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output Willem de Bruijn
2025-02-28 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8DYMBlzcK5sFG-M@google.com \
--to=krakauer@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).