Re: [PATCH net-next v8 08/12] net: ethtool: try to protect all callback with netdev instance lock

[Stanislav Fomichev <stfomichev@gmail.com>]

On 02/27, Maxime Chevallier wrote:
> Hi,
> 
> On Wed, 26 Feb 2025 13:11:04 -0800
> Stanislav Fomichev <sdf@fomichev.me> wrote:
> 
> > From: Jakub Kicinski <kuba@kernel.org>
> > 
> > Protect all ethtool callbacks and PHY related state with the netdev
> > instance lock, for drivers which want / need to have their ops
> > instance-locked. Basically take the lock everywhere we take rtnl_lock.
> > It was tempting to take the lock in ethnl_ops_begin(), but turns
> > out we actually nest those calls (when generating notifications).
> > 
> > Cc: Saeed Mahameed <saeed@kernel.org>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
> > ---
> >  drivers/net/netdevsim/ethtool.c |  2 --
> >  net/dsa/conduit.c               | 16 +++++++++++++++-
> >  net/ethtool/cabletest.c         | 20 ++++++++++++--------
> >  net/ethtool/cmis_fw_update.c    |  7 ++++++-
> >  net/ethtool/features.c          |  6 ++++--
> >  net/ethtool/ioctl.c             |  6 ++++++
> >  net/ethtool/module.c            |  8 +++++---
> >  net/ethtool/netlink.c           | 12 ++++++++++++
> >  net/ethtool/phy.c               | 20 ++++++++++++++------
> >  net/ethtool/rss.c               |  2 ++
> >  net/ethtool/tsinfo.c            |  9 ++++++---
> >  net/sched/sch_taprio.c          |  5 ++++-
> >  12 files changed, 86 insertions(+), 27 deletions(-)
> 
> FWIW I've tested that patchset with various PHY-related ethtool ops as
> well as the module ops and didn't notice any issue or strangeness.
> 
> So to some extent,
> 
> Tested-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Thank you for testing!