From: Stanislav Fomichev <stfomichev@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
eric.dumazet@gmail.com, Kui-Feng Lee <kuifeng@meta.com>,
Martin KaFai Lau <martin.lau@kernel.org>
Subject: Re: [PATCH bpf-next] bpf: no longer acquire map_idr_lock in bpf_map_inc_not_zero()
Date: Sat, 1 Mar 2025 16:05:34 -0800 [thread overview]
Message-ID: <Z8OgzrmLG0uvrsR_@mini-arch> (raw)
In-Reply-To: <20250301191315.1532629-1-edumazet@google.com>
On 03/01, Eric Dumazet wrote:
> bpf_sk_storage_clone() is the only caller of bpf_map_inc_not_zero()
> and is holding rcu_read_lock().
>
> map_idr_lock does not add any protection, just remove the cost
> for passive TCP flows.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
next prev parent reply other threads:[~2025-03-02 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 19:13 [PATCH bpf-next] bpf: no longer acquire map_idr_lock in bpf_map_inc_not_zero() Eric Dumazet
2025-03-02 0:05 ` Stanislav Fomichev [this message]
2025-03-03 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8OgzrmLG0uvrsR_@mini-arch \
--to=stfomichev@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kuifeng@meta.com \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).