netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rasesh Mody <rmody@marvell.com>,
	GR-Linux-NIC-Dev@marvell.com, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v1 1/1] bnx2: Fix unused data compilation warning
Date: Tue, 4 Mar 2025 12:56:41 +0200	[thread overview]
Message-ID: <Z8bcaR9MS7dk8Q0p@smile.fi.intel.com> (raw)
In-Reply-To: <20250303172114.6004ef32@kernel.org>

On Mon, Mar 03, 2025 at 05:21:14PM -0800, Jakub Kicinski wrote:
> On Fri, 28 Feb 2025 12:05:37 +0200 Andy Shevchenko wrote:
> > In some configuration, compilation raises warnings related to unused
> > data. Indeed, depending on configuration, those data can be unused.
> > 
> > Mark those data as __maybe_unused to avoid compilation warnings.
> 
> Will making dma_unmap_addr access the first argument instead of
> pre-processing down to nothing not work?

I looked at the implementation of those macros and I have no clue
how to do that in a least intrusive way. Otherwise it sounds to me
quite far from the scope of the small compilation error fix that
I presented here.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-03-04 10:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 10:05 [PATCH net v1 1/1] bnx2: Fix unused data compilation warning Andy Shevchenko
2025-03-04  1:21 ` Jakub Kicinski
2025-03-04 10:56   ` Andy Shevchenko [this message]
2025-03-04 11:39     ` Paolo Abeni
2025-03-04 11:58       ` Andy Shevchenko
2025-03-04 13:41         ` Andy Shevchenko
2025-03-04 16:35           ` Jakub Kicinski
2025-03-05 10:00             ` Andy Shevchenko
2025-03-11 12:51               ` Marek Szyprowski
2025-03-12 16:20                 ` Andy Shevchenko
2025-04-14 10:08                   ` Andy Shevchenko
2025-04-15  9:43                     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8bcaR9MS7dk8Q0p@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmody@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).