Re: [PATCH net-next 07/14] devlink: Implement port params registration

Przemek Kitszel
2025-02-28T11:59:29Z

On 2/28/25 03:12, Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
>
> Port params infrastructure is incomplete and needs a bit of plumbing to
> support port params commands from netlink.
>
> Introduce port params registration API, very similar to current devlink
> params API, add the params xarray to devlink_port structure and
> decouple devlink params registration routines from the devlink
> structure.
>
> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> ---
> include/net/devlink.h | 14 ++++
> net/devlink/param.c | 150 ++++++++++++++++++++++++++++++++++--------
> net/devlink/port.c | 3 +
> 3 files changed, 140 insertions(+), 27 deletions(-)
For me devlink and devlink-port should be really the same, to the point
that the only difference is `bool is_port` flag inside of the
struct devlink. Then you could put special logic if really desired (to
exclude something for port).
Then for ease of driver programming you could have also a flag
"for_port" in the struct devlink_param, so developers will fill that
out statically and call it on all their devlinks (incl port).

Multiplying the APIs instead of rethinking a problem is not a good long
term solution.