From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] selftests: net: fix error message in bpf_offload
Date: Tue, 4 Mar 2025 16:10:13 -0800 [thread overview]
Message-ID: <Z8eWZSuDU4Q4q5UM@mini-arch> (raw)
In-Reply-To: <20250304233204.1139251-1-kuba@kernel.org>
On 03/04, Jakub Kicinski wrote:
> We hit a following exception on timeout, nmaps is never set:
>
> Test bpftool bound info reporting (own ns)...
> Traceback (most recent call last):
> File "/home/virtme/testing-1/tools/testing/selftests/net/./bpf_offload.py", line 1128, in <module>
> check_dev_info(False, "")
> File "/home/virtme/testing-1/tools/testing/selftests/net/./bpf_offload.py", line 583, in check_dev_info
> maps = bpftool_map_list_wait(expected=2, ns=ns)
> File "/home/virtme/testing-1/tools/testing/selftests/net/./bpf_offload.py", line 215, in bpftool_map_list_wait
> raise Exception("Time out waiting for map counts to stabilize want %d, have %d" % (expected, nmaps))
> NameError: name 'nmaps' is not defined
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
I've seen this a couple of times myself but was too lazy to send out
a fix :-[
next prev parent reply other threads:[~2025-03-05 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 23:32 [PATCH net-next 1/2] selftests: net: fix error message in bpf_offload Jakub Kicinski
2025-03-04 23:32 ` [PATCH net-next 2/2] selftests: net: bpf_offload: add 'libbpf_global' to ignored maps Jakub Kicinski
2025-03-05 0:10 ` Stanislav Fomichev
2025-03-05 0:10 ` Stanislav Fomichev [this message]
2025-03-07 0:50 ` [PATCH net-next 1/2] selftests: net: fix error message in bpf_offload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8eWZSuDU4Q4q5UM@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).