netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	shuah@kernel.org, pshelar@ovn.org, aconole@redhat.com,
	amorenoz@redhat.com, linux-kselftest@vger.kernel.org,
	dev@openvswitch.org
Subject: Re: [PATCH net-next] selftests: openvswitch: don't hardcode the drop reason subsys
Date: Tue, 4 Mar 2025 16:17:01 -0800	[thread overview]
Message-ID: <Z8eX_WaLGCrM8QhA@mini-arch> (raw)
In-Reply-To: <20250304180615.945945-1-kuba@kernel.org>

On 03/04, Jakub Kicinski wrote:
> WiFi removed one of their subsys entries from drop reasons, in
> commit 286e69677065 ("wifi: mac80211: Drop cooked monitor support")
> SKB_DROP_REASON_SUBSYS_OPENVSWITCH is now 2 not 3.
> The drop reasons are not uAPI, read the correct value
> from debug info.
> 
> We need to enable vmlinux BTF, otherwise pahole needs
> a few GB of memory to decode the enum name.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Acked-by: Stanislav Fomichev <sdf@fomichev.me>

Might have resolved OVS_DROP_FLOW_ACTION and the rest as well via
pahole, but assuming these won't be reordered/removed too often..

  reply	other threads:[~2025-03-05  0:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 18:06 [PATCH net-next] selftests: openvswitch: don't hardcode the drop reason subsys Jakub Kicinski
2025-03-05  0:17 ` Stanislav Fomichev [this message]
2025-03-05  0:48 ` [ovs-dev] " Aaron Conole
2025-03-07  1:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8eX_WaLGCrM8QhA@mini-arch \
    --to=stfomichev@gmail.com \
    --cc=aconole@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pshelar@ovn.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).