From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, Andrew Lunn <andrew@lunn.ch>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH net-next v2 06/10] net: usb: lan78xx: Improve error handling in EEPROM and OTP operations
Date: Thu, 6 Mar 2025 09:48:04 +0100 [thread overview]
Message-ID: <Z8lhRCkxvtkB_U3x@pengutronix.de> (raw)
In-Reply-To: <ac965de8-f320-430f-80f6-b16f4e1ba06d@sirena.org.uk>
Hi Mark,
On Mon, Mar 03, 2025 at 06:02:23PM +0000, Mark Brown wrote:
> On Wed, Dec 04, 2024 at 09:41:38AM +0100, Oleksij Rempel wrote:
> > Refine error handling in EEPROM and OTP read/write functions by:
> > - Return error values immediately upon detection.
> > - Avoid overwriting correct error codes with `-EIO`.
> > - Preserve initial error codes as they were appropriate for specific
> > failures.
> > - Use `-ETIMEDOUT` for timeout conditions instead of `-EIO`.
>
> This patch (which is in Linus' tree) appears to break booting with a NFS
> root filesystem on Raspberry Pi 3B+. There appears to be at least no
> incoming traffic seen on the device, I've not checked if there's
> anything outgoing:
>
> [ 19.234086] usb 1-1.1.1: new high-speed USB device number 6 using dwc2
> [ 19.394134] brcmfmac: brcmf_sdio_htclk: HT Avail timeout (1000000): clkctl 0x50
> [ 19.710839] lan78xx 1-1.1.1:1.0 enxb827ebea22ac: renamed from eth0
> Device /sys/class/net/enxb827ebea22ac found
> done.
> Begin: Waiting up to 180 secs for any network device to become available ... done.
> IP-Config: enxb827ebea22ac hardware address b8:27:eb:ea:22:ac mt[ 20.663606] lan78xx 1-1.1.1:1.0 enxb827ebea22ac: Link is Down
> u 1500 DHCP
> [ 22.708103] lan78xx 1-1.1.1:1.0 enxb827ebea22ac: Link is Up - 1Gbps/Full - flow control off
> IP-Config: no response after 2 secs - giving up
I can't reproduce it without U-boot. Since netboot is used, this adapter
stays in some kind of preconfugured state. Where can I get the SD image
which is used on this system?
Best Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-03-06 8:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 8:41 [PATCH net-next v2 00/21] lan78xx: Preparations for PHYlink Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 01/10] net: usb: lan78xx: Remove LAN8835 PHY fixup Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 02/10] net: usb: lan78xx: Remove KSZ9031 " Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 03/10] net: usb: lan78xx: move functions to avoid forward definitions Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 04/10] net: usb: lan78xx: Improve error reporting with %pe specifier Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 05/10] net: usb: lan78xx: Fix error handling in MII read/write functions Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 06/10] net: usb: lan78xx: Improve error handling in EEPROM and OTP operations Oleksij Rempel
2025-03-03 18:02 ` Mark Brown
2025-03-04 5:40 ` Oleksij Rempel
2025-03-06 8:48 ` Oleksij Rempel [this message]
2025-03-06 13:17 ` Mark Brown
2024-12-04 8:41 ` [PATCH net-next v2 07/10] net: usb: lan78xx: Add error handling to lan78xx_init_ltm Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 08/10] net: usb: lan78xx: Add error handling to set_rx_max_frame_length and set_mtu Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 09/10] net: usb: lan78xx: Add error handling to lan78xx_irq_bus_sync_unlock Oleksij Rempel
2024-12-04 8:41 ` [PATCH net-next v2 10/10] net: usb: lan78xx: Improve error handling in dataport and multicast writes Oleksij Rempel
2024-12-07 1:55 ` [PATCH net-next v2 00/21] lan78xx: Preparations for PHYlink Jakub Kicinski
2024-12-07 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8lhRCkxvtkB_U3x@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).