From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00B7148FF5; Thu, 6 Mar 2025 15:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741275887; cv=none; b=fYQYxO63SXqApByXCT8A8Nvd+PlDkKti0xdhGyIeKi96sqkmZ4OfPoagEkNjO34NzV//s6xljsMz16DyZHyE2CSVA7nwXxTOfxAV/14d8gNmKhGhL/R5ML9jnCyHe1Mp1PmroLHX3V51Zgol62V4mGBEug36t/6ZfKbjGxN5FqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741275887; c=relaxed/simple; bh=aixKISa0kyko036hL5V+qG8LL9qF3VO6FIAxvZvxJ70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E1b5oS+VmPT+Smfy7w3WnN2IzyEnfQjqxaUjsr4H7gYWaLAhLC/SLMV/8oie7uA4AWxOtXBVAMc8lFsYMABDbk/LckkKHB8qFsdT9oiizCTQ7uWXXJmReKFq/dlPGkP23EFOVqoFzkqhl8sAxemuenXQUdMzYnFLx7Gnn9mG390= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=zg5fWzzg; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="zg5fWzzg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iqLTGgFW/Idb/RWJchf5+oj54Xp1Xr/3EggXQFnKjbg=; b=zg5fWzzg0ciofiTPI5rB/vbzNy WfPtrhrK/GWO2fk4YllvIpM+OR9zwj+nAcHdFxGejKYSLJxFb14lamIUz029dUennkO+S/8xVwuKc pWpGlU0OakPqbwkewGvaK7xfdpzRob+q6JwaxaXhNoWbqP9Op+aRtpsOdJre4ZOSQX1nrxyDbY+36 dwWYXr59SJGNLnf9PF1mlryhiM4aHClD6+aAm22Y4/shvpvQn0l2CNkrHW7lUv7g6/QFOfOTssfz+ 4myjdw/1c6uQYOEnEyXLxfIhfWMGyWFfhFtY6V5aE6sU8xkDUpYR9cz8mguYi05IG5uCLynbEIjiF Xtu/bAfA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36454) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tqDOj-00067c-2X; Thu, 06 Mar 2025 15:44:33 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tqDOh-0006uz-01; Thu, 06 Mar 2025 15:44:31 +0000 Date: Thu, 6 Mar 2025 15:44:30 +0000 From: "Russell King (Oracle)" To: Jon Hunter Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Thierry Reding , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH RFC 0/5] net: stmmac: fix resume failures due to RX clock Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Thu, Mar 06, 2025 at 11:30:53AM +0000, Jon Hunter wrote: > Hi Russell, > > On 27/02/2025 14:37, Russell King (Oracle) wrote: > > Hi, > > > > This series is likely dependent on the "net: stmmac: cleanup transmit > > clock setting" series which was submitted earlier today. > > I tested this series without the above on top of mainline and I still saw > some issues with suspend. However, when testing this on top of -next (which > has the referenced series) it works like a charm. So yes it does appear to > be dependent indeed. > > I have tested this on Tegra186, Tegra194 and Tegra234 with -next and all are > working fine. So with that feel free to add my ... > > Tested-by: Jon Hunter Hi Jon, I came up with an alternative approach which should make this safer - for example, if the PHY remains linked with the partner over an ifdown or module remove/re-insert. Please see v2 of "net: stmmac: approach 2 to solve EEE LPI reset issues" which replaces this series. https://lore.kernel.org/r/Z8m-CRucPxDW5zZK@shell.armlinux.org.uk Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!