From: Joe Damato <jdamato@fastly.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
alexanderduyck@fb.com
Subject: Re: [PATCH net-next 2/3] eth: fbnic: fix typo in compile assert
Date: Thu, 6 Mar 2025 09:13:17 -0800 [thread overview]
Message-ID: <Z8nXrbFjvFo-d4hH@LQ3V64L9R2> (raw)
In-Reply-To: <20250306145150.1757263-3-kuba@kernel.org>
On Thu, Mar 06, 2025 at 06:51:49AM -0800, Jakub Kicinski wrote:
> We should be validating the Rx count on the Rx struct,
> not the Tx struct. There is no real change here, rx_stats
> and tx_stats are instances of the same struct.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Good catch.
Acked-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-03-06 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 14:51 [PATCH net-next 0/3] eth: fbnic: support ring size configuration Jakub Kicinski
2025-03-06 14:51 ` [PATCH net-next 1/3] eth: fbnic: link NAPIs to page pools Jakub Kicinski
2025-03-06 17:12 ` Joe Damato
2025-03-06 14:51 ` [PATCH net-next 2/3] eth: fbnic: fix typo in compile assert Jakub Kicinski
2025-03-06 17:13 ` Joe Damato [this message]
2025-03-06 14:51 ` [PATCH net-next 3/3] eth: fbnic: support ring size configuration Jakub Kicinski
2025-03-06 18:05 ` Joe Damato
2025-03-08 3:50 ` [PATCH net-next 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8nXrbFjvFo-d4hH@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox