From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Heiko Stuebner <heiko@sntech.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 2/2] net: stmmac: dwmac-rk: Validate rockchip,grf and php-grf during probe
Date: Thu, 6 Mar 2025 21:21:12 +0000 [thread overview]
Message-ID: <Z8oRyHThun9mLgx8@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250306210950.1686713-3-jonas@kwiboo.se>
On Thu, Mar 06, 2025 at 09:09:46PM +0000, Jonas Karlman wrote:
> @@ -1813,8 +1564,24 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
>
> bsp_priv->grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> "rockchip,grf");
> - bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node,
> - "rockchip,php-grf");
> + if (IS_ERR(bsp_priv->grf)) {
> + ret = PTR_ERR(bsp_priv->grf);
> + dev_err_probe(dev, ret, "failed to lookup rockchip,grf\n");
> + return ERR_PTR(ret);
Did you consider using ERR_CAST() for these, which would look like this:
dev_err_probe(dev, PTR_ERR(bsp_priv->grf),
"failed to lookup rockchip,grf\n");
return ERR_CAST(bsp_priv->grf);
?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-03-06 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 21:09 [PATCH 0/2] net: stmmac: dwmac-rk: Validate rockchip,grf and php-grf during probe Jonas Karlman
2025-03-06 21:09 ` [PATCH 1/2] dt-bindings: net: rockchip-dwmac: Require rockchip,grf and rockchip,php-grf Jonas Karlman
2025-03-06 22:32 ` Andrew Lunn
2025-03-06 23:42 ` Jonas Karlman
2025-03-06 21:09 ` [PATCH 2/2] net: stmmac: dwmac-rk: Validate rockchip,grf and php-grf during probe Jonas Karlman
2025-03-06 21:21 ` Russell King (Oracle) [this message]
2025-03-06 23:14 ` Jonas Karlman
2025-03-06 22:37 ` Andrew Lunn
2025-03-06 23:49 ` Jonas Karlman
2025-03-07 16:55 ` Jakub Kicinski
2025-03-07 17:15 ` Andrew Lunn
2025-03-07 18:22 ` Russell King (Oracle)
2025-03-07 18:50 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8oRyHThun9mLgx8@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).