From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D51F21767D; Fri, 7 Mar 2025 12:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741349478; cv=fail; b=qX6u1kCg/z1W14veh6EI4CoujKFen2blSp3Hzl6Ou0LG5WIpUKd3IiYtfCZebq8V2kRlZOh+dWAD4ScjH6whI7Dj+FpVJoXyRcqn7vZZfrKmykNKI66JbIB5LGJU3fNO17AJaObP8NAMxeEjpEq/hYHms2G38fB4T6HbCrKC/o4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741349478; c=relaxed/simple; bh=rMmgzhegAq0gg/ML2c0n5IhLVaVzrE4XebCzt5gckd8=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=X2vX+7zcjLbIpkoOynMq0rCU5fR8WRXgJc7aBnqKwtIJW1PWbbZRRjcEqJESLr21LFNg70HIMMSVnvah9Kdqxx9PUMw3idWs5v3mZ+BFOzSsUcZ85gS1q6Y5JZFUWk3xHPiuPrGKe11vdzQwkxvmnv4QmKTGLdh88rLZ1opviu0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T2XH7+Le; arc=fail smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T2XH7+Le" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741349478; x=1772885478; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=rMmgzhegAq0gg/ML2c0n5IhLVaVzrE4XebCzt5gckd8=; b=T2XH7+LekKUEDK/a28BAdSF/YDtvF9S4kazsI3YrIoM0ik3oXqU+ixhm 9XBtToHUgl7uYzMAwzbsfbiSL5Q2IXK4YvV+dQgPIqTDEa8y1ncOiGJYM A8yj2WDHiCCGwdGRU3DYSVx2CR6RPTIlLjWcNhOoAJvSV2ghz2YCRnpb8 oBKFmo+ZxCOqcvQKoct1Gs0ueGvkR57XiYeOIs7NEw1b5cdXWWk02Qw2a eFLmxcfFMYzy+9A6xFaq4RWLOERl9epMEzYl8GCDBz7pb6wgLRZIl73wG a8ZxkmzeOPuxd0D8EtCBARmqqnW3XH4xZFA0Mw+eREh+INECve6zgPAGl g==; X-CSE-ConnectionGUID: 1CZknhU8RYGhRkUxxcIuNg== X-CSE-MsgGUID: F009FyDaTSW45MVGfMfqAw== X-IronPort-AV: E=McAfee;i="6700,10204,11365"; a="53036704" X-IronPort-AV: E=Sophos;i="6.14,229,1736841600"; d="scan'208";a="53036704" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2025 04:11:15 -0800 X-CSE-ConnectionGUID: vpuhkLu+SYWPDPuoc0gAqA== X-CSE-MsgGUID: C8Zz6ZbYR+2Uy5Celo0uLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,229,1736841600"; d="scan'208";a="142540548" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Mar 2025 04:11:14 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 7 Mar 2025 04:11:13 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Fri, 7 Mar 2025 04:11:13 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 7 Mar 2025 04:11:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s12w0FJgbDBZDJtCykOcojET6iXAoerAck20L6hroQGPfyQLOC+CfwgTgMI7FuBOlB9ZNkZUGmKsSeiH8Pns3kLZvu6vKWG9jkl2fGcVtL0DTyPoBhQrOdnA+vxJaWThFvk7wG/YFGp8Q+TCpJXmPwFBVvNLnVM24Hv5WAQ1PMfKRe2P1bPT1vwMLPS1Gg/3e9LwjRR7ilPQnZphYe2BKM5dHIVxImd7NiOqfI4MtFX505mEO25bpHBT7eACAubKHcUq3+bryeT/7Rj+4p9708pw1dPjQ/aYjE3i7VsJv5iuCcx5RyZUVAnSsMsHlspflc3aLVhkpCTDtB6/Dctw7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1mggZABp1JgUicXztc9zb8YYWZ1M5nYMn67DABoOGY0=; b=Fwx/OpeA9d81Bc6mDgWQAjmUr407vPjH+OAHztqwzGJ7zq0jYLFV+kqZ7IYeUCSN/hCehEV07omjTNVXRUU7vNvIoiiKlLp/T4sUgvz0AETQna/xqplIgeSg+uFCvXG4jhfZ5LKqkI9T0gFA2id3HNiMCVYnMa+hnBd6KGX34iadXp525eMZRNQcGA/Zn3QVerAErUN0cgAddlWdNZ+8W7RW21eG/Hd05pBRwXN148lCyzpIYqtg1+biIuq07hCUSRvj7u+hABCfEES7z1DZGLdZ35/XAVeIR+chDIX8ONhc1kFlihZcZQyhdq0B0LJ5jdAN7bvQ6wnTFZgSBYvRbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) by CH0PR11MB8234.namprd11.prod.outlook.com (2603:10b6:610:190::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.19; Fri, 7 Mar 2025 12:10:42 +0000 Received: from DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::d19:56fe:5841:77ca]) by DM4PR11MB6117.namprd11.prod.outlook.com ([fe80::d19:56fe:5841:77ca%3]) with mapi id 15.20.8511.017; Fri, 7 Mar 2025 12:10:41 +0000 Date: Fri, 7 Mar 2025 13:10:29 +0100 From: Maciej Fijalkowski To: Alexander Lobakin CC: , Michal Kubiak , Tony Nguyen , "Przemek Kitszel" , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Alexei Starovoitov" , Daniel Borkmann , "Jesper Dangaard Brouer" , John Fastabend , Simon Horman , , , Subject: Re: [PATCH net-next 10/16] idpf: add support for nointerrupt queues Message-ID: References: <20250305162132.1106080-1-aleksander.lobakin@intel.com> <20250305162132.1106080-11-aleksander.lobakin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250305162132.1106080-11-aleksander.lobakin@intel.com> X-ClientProxiedBy: WA1P291CA0022.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:19::29) To DM4PR11MB6117.namprd11.prod.outlook.com (2603:10b6:8:b3::19) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6117:EE_|CH0PR11MB8234:EE_ X-MS-Office365-Filtering-Correlation-Id: f053be17-f22a-4326-ad95-08dd5d7114b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yE/38aJqNjEOHW+m2lRwLj+ZHwtTyXpEtlKpc6p9UJYwGAKN9+TM4t9rMV9C?= =?us-ascii?Q?zLZ4ogwTvDy+mjTxiaNH8RBybTq9PJ0UhFv4eYtRCU66K88xdVi2PnlBhSco?= =?us-ascii?Q?9WSuX8ZDLuJJ+G+BglP2mhs9+PYZm4TYyroGPyC+t1ed/OT2CAaN+WXWTyue?= =?us-ascii?Q?PEJ7563Xxh8HRjEaYlODqjEvnX0FwsdllEhmrIjdMhT963pxxjuTMuDr9JfT?= =?us-ascii?Q?ac0gwfbPbwYg+pdF6U/U9bS/YvZg4U8oV/V+v0ub7Mqrpn2Xcv1mHk46Pb5f?= =?us-ascii?Q?ErudCVNsLqO34AWKaMww3mc3/ctSu3kwNnwQef5ZRMFvRSKQ/Jq4o21DdVlq?= =?us-ascii?Q?0dKSNTDTTP+HchtmN/50MzwSNfb259/p9iG84CUUzoaEEQI0DUlvc7zigUtv?= =?us-ascii?Q?qRiVbmz9vfQbLmPvhBMpgUn6LFTnhlZ/ex/ZDGqYmGRnDgYZcTEi1dfBg3pD?= =?us-ascii?Q?XsvfM3iFUCmh6QjTNkeK8Moww13jRo4ptOcwAbxuGmwywPA3+RJsR4p0vPaf?= =?us-ascii?Q?/lK86n+ojvDwTKpn7qagIuGyw1iYZccw6TcN5GA4d5wSBgY8X5/mGXbNgDGm?= =?us-ascii?Q?5WvQ+Yd+8O2NmTGAkA8OIQgDM5tq40gtMkXnu4MdUpXR4sag7PDOxQYfCmjG?= =?us-ascii?Q?PXvjxLHjxkncb//f1hVH8N1j7bpk9//4QF0/KqCSntq/aI4yAsKhdLzPJh4p?= =?us-ascii?Q?HQnNaLzktedGeLMn9UZz30/ZmaRF5fgoiI/2mn9SpIoAPx6j6ShHDTv9eyy3?= =?us-ascii?Q?z5IDWGn5eR40bjqZc9z1yB65szugSgmTV4uycQG/ZoTdFyj3VavxKBNubkb/?= =?us-ascii?Q?38HMthQTNrq9Tv+xJ9LAFNUp9IwOcIYVbJNlghS2K4Z/Pcu6OypG3daZ9C+c?= =?us-ascii?Q?1L2ouY3pZ0k6L740C2zmXWNSNYTiWYQ+upGHI9nVdciKqtkr2jvdSWJeG6Pu?= =?us-ascii?Q?vTc7Blm0/DT3LI19YjBsJDB2sb72/ThjgN3LyLdJ2M0OtiuyUygdJ8Z14uHg?= =?us-ascii?Q?BSPXnrVQT9N/6/S8rQ0vpwou0QiJ91YlzGRGIZYPbIei7RksF1Qx6UbpWBFV?= =?us-ascii?Q?ZipCXgHhZAU9rjMHLxLQ07Qe8V4jrdMfTlSzVxebuwYRJqpUmcTxno45PHOF?= =?us-ascii?Q?Yth+qv1NauaY2FhTcYNoNPbsaTPzUMgUMlPN8ZjkMmT4YbJiJfoB/cAGdJ+9?= =?us-ascii?Q?v5SmytJvSXV24UJEeuWB8zkw1ew64zokqhnn83FgDoqzz6mcIASA5MKI2lg0?= =?us-ascii?Q?AmG+Zj7huvwmSlwoIt6PyXnNUAn6OBY017WR9VdSZ3RamFZ1E1Aao45jYvOR?= =?us-ascii?Q?ftE7lnDF0H6ynvPb7dQq93Ux58sq0ACzlm+PrUn+eeqQhYYNNV/SFQ6q7awH?= =?us-ascii?Q?pJ5SRqZoZcqYFcBP+QjIhepJb+Zd?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6117.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B4bhgstGbVFojj6uU5SrZV+VfMfFS9uIPTTCWWGm7ENvSSfbXl3kxaqzJPW6?= =?us-ascii?Q?13ajUnjxmJjt22AJeFszgaUV2Zb7ZJaLYZGWkWH9VrnLZKVtI/EjwXW9k72D?= =?us-ascii?Q?wXO4W+Qp/Ai9VolRqDTgWoPucneW1zPjcvyGkb56NycIikBeYV2nyU+zkcZA?= =?us-ascii?Q?LjtMcNeNznaQSwbA6CvnTD4bo2dwdBHd4Yk7CSLAWknY3i7dqJqMvcW+0x8M?= =?us-ascii?Q?SOw+4Axghj3dIgabrlo5hZm72HxkfhuSVHca8HO65SsMhEND15gGkAplGpww?= =?us-ascii?Q?utr5tSKfbo9vTeKqmjSf6CWg0sZIrTqyFkN0MwwYBSEewwHaE3FDcLNaY17b?= =?us-ascii?Q?+cuMHPWov8oDVBbMaeaSwqfuN7b5kJOZG3vUTgpsoeCmPCAO2G/h4hsbOQlt?= =?us-ascii?Q?7EUJ2Nluqo+Wt39iIpkWxttDJ2aI7NR0+TxEvtRAhzLIUNHR2pt4rxtDcEZd?= =?us-ascii?Q?ZypRYqyn7L11cDCRw5/yjXv4j1XINcwdFu91nXk4sCpHiVEl6q3vD9cCJ7nT?= =?us-ascii?Q?HEQJwZpqIJZeztJ2+nMi+1K2QRaDzkXcCeVUTUDv5WfzWD0sBWxZV34xUt5a?= =?us-ascii?Q?aBWqeOgI91hPEC2+Z4Hy6YXL+dNJ3pvxYBXIYvRc4pO9UBE0j9hBc2q9xlSY?= =?us-ascii?Q?hOKSh6rQ4tUBW6xwWtY0rByuOfLAwygKH1Le2GjmCtxJEzeW9VqbX5Poiwie?= =?us-ascii?Q?8zkKkyB5GX+dbjqbRyNvgn/bjLtRy3wT/mqgQoqv2OEKyrwiDaHsvQnGTqmj?= =?us-ascii?Q?AtctOqgm6syDHtYcW5qDBkDhoz4iM5NYI74Hlx64CKS6hJ916T2m1TJDKeeJ?= =?us-ascii?Q?/cYIxxgQPIU5IQKwUJwiFGe63avOK4Ph4262SNDhiwXJF1d/BSxc9ItdFK+8?= =?us-ascii?Q?jda7u8U/z8s8NxZheI2v04COwd+vc3ChZ3kJWJgMcC1IQvy8i8wXzQrTiu4J?= =?us-ascii?Q?sfkozXjx1vW49+SsT/rg+YJMX1JKBt+lLnCuk/39ZuDR41XYrZrfuRBm6lwA?= =?us-ascii?Q?jszijkbk1uTkxbnwtYELb35U+hs9uv2vbgPrApT5+k08RjBGKsolYeFnZsML?= =?us-ascii?Q?urZlNaY+Tzs2g4Q5+HENeMX/XeodEb3DL3a33CrGUWajsLlEdbdwqtbV1iJ5?= =?us-ascii?Q?s6mpwlJ5UIHMWqGNu4LZP1YGR0B3rScHJ2RL6sXGBsH8zwsVvxktVxFpCpYp?= =?us-ascii?Q?errk5CQxhBqVZYHOk5xlo7DjsIjozpoJmIyKv7KIWpGPvZ8DHkjNcQwPTQYQ?= =?us-ascii?Q?M+VgyQc0Jfrt/IZNTvYemf4B1Xlgdz37Xy4AQKsPVbXTwwh+xGF6EXk/71Ln?= =?us-ascii?Q?id2VfW/OWYcKVryhWRZqekZicOzIck2XpIrgCt86ZTHy7D5sjgwa+ORUt7o9?= =?us-ascii?Q?s5nAkFMAVdH8+L94/ayLZ9qMlFKXIrvV0ktIzOmsUiiV+6jcAA/QetcyvbmD?= =?us-ascii?Q?d8nPmTm5hrNki2PX27FVhh1J1Np1wUv0NIPWMOsS7K2pJMEEkac69dtVMoA5?= =?us-ascii?Q?jtrh/NINDGJIo0XeYICcZ+yvRdFgD5Knjwd3/CXvjfPiROWC0j5HT8EWMdL7?= =?us-ascii?Q?ndYKPR07sRP7inDuO6DizbDcHYSbNrF7qv2Y35bQaduuV6OarUm+KP65EV95?= =?us-ascii?Q?Qw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f053be17-f22a-4326-ad95-08dd5d7114b3 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2025 12:10:41.7702 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6/TFoyZ+dlB+tjeb/NMnWCOInzwTePz0h+LFkmo1+eOeF1OyAPvbQN8GswJlZ1OM03pQpi9v/BMKoPm3RxYWkVCp0d7jWQtRlIJ2JDYx3Pg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8234 X-OriginatorOrg: intel.com On Wed, Mar 05, 2025 at 05:21:26PM +0100, Alexander Lobakin wrote: > Currently, queues are associated 1:1 with interrupt vectors as it's > assumed queues are always interrupt-driven. > In order to use a queue without an interrupt, idpf still needs to have > a vector assigned to it to flush descriptors. This vector can be global > and only one for the whole vport to handle all its noirq queues. > Always request one excessive vector and configure it in non-interrupt > mode right away when creating vport, so that it can be used later by > queues when needed. Description sort of miss the purpose of this commit, you don't ever mention that your design choice for XDP Tx queues is to have them irq-less. > > Co-developed-by: Michal Kubiak > Signed-off-by: Michal Kubiak > Signed-off-by: Alexander Lobakin > --- > drivers/net/ethernet/intel/idpf/idpf.h | 8 +++ > drivers/net/ethernet/intel/idpf/idpf_txrx.h | 4 ++ > drivers/net/ethernet/intel/idpf/idpf_dev.c | 11 +++- > drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 +- > drivers/net/ethernet/intel/idpf/idpf_txrx.c | 8 +++ > drivers/net/ethernet/intel/idpf/idpf_vf_dev.c | 11 +++- > .../net/ethernet/intel/idpf/idpf_virtchnl.c | 53 +++++++++++++------ > 7 files changed, 79 insertions(+), 18 deletions(-)