From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD1C222A7FF for ; Fri, 21 Mar 2025 16:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742575001; cv=none; b=kxeX0lR4I0lVeZXWVyDiR92wLSwzoKAVEQkJznQAJIy5fMSFplsDZq+u/J4OIs5xQRKHA0XKP4nqD/UkmRV6i0t6XJ4Yr/3HZ45zxvtS70wPgPZELkHqoc9KA2dQJNATpRqUx8JE4MzOTsCVSoczWwTYtbWdwSwrlHR8ODQPWTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742575001; c=relaxed/simple; bh=Hjm+6X18HfhpHIGsOF0Wa+HjL7J2VCrd/SOk7TvJe8g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HfGG/omqY/8nmmpe8FKiKedOYqDDLiR1yEekEZIgHQ1cCgvIhcDqXpuWVfFPusu7DL9GMRRJof9DZIcg5/abosoVfmOgS//baq8pTERZLY7K4oE+H5s5KnQNab9Z9Oj+Gx/6Djg47PvfPCwv36yYIFHzPup5BiG2XgbgKxbAGho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=MZHWkbQV; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="MZHWkbQV" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-22435603572so43054275ad.1 for ; Fri, 21 Mar 2025 09:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1742574999; x=1743179799; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=YALLnLfNqwU57i7wtFxN8i/4pwzBbw+w8xRGUYxzetU=; b=MZHWkbQV4x7bg/O4wFFFfRPlZtESaA0v8NXS4bwNrJ6AjgL6ju53tkdph3LJaiNMme Uzvt2rfsKBGYwXhkxusFMsVdUZtocME/uedeyElNWYuFM0pXYRhGn+chWuHm1avPkY+e bLTWDD3vMSIqEuSER+745abq7dnQ3YJWC0/HI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742574999; x=1743179799; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YALLnLfNqwU57i7wtFxN8i/4pwzBbw+w8xRGUYxzetU=; b=dTZ/kKon/C4RkeIj4yI3drg40wtAB87z+ht8G+V5qNNAemQMNsVZwU/AYQGvu5Pfqh tttVQQrxofikWzUAG7b3iMuj0p5IdjsQpz2aA46IAgA0INnmSkDZlDZXRVz4gtzsGI2w 3JrjrKojnhVSPit9HGc2hIy2zOLs6/vhY8M+5vDDoZjpjklmD/Pung/OxQ3QeUQWfyTo x5e6lz3bhsr5OhQ0RbuoD/nR5t2b6dYUh4S1Gka4pEX2QxsokPlQEIdzs0QnRLjphVbe EEa33QV0vxvOw7rE9Vg5bNviPsRCfiBR8zcBYzELGDclU+JrAPJlAJTtrVFZo6395Hsb nu9g== X-Forwarded-Encrypted: i=1; AJvYcCVm5EmhLZuqtpep1dvlah4SHTYeTbdOa/5F3K1IsP1U6XLfAC0pSgnP/s+UMssNwOIzUOrFz/c=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3GxEwDXBFjzXDYdVxby4WFNMDqCWPgHg/c+1ZOEydSBcKOsXj Ilj1Nfl+CNJPBwHivm3N0Gar65UdRia8FlLUMxy3kL+pBvIBrZenFoLFA7mKAUs= X-Gm-Gg: ASbGncusY/qnb5mUAShl+JLRowJgmRGFyDpiOHEU9CtZ9GacegyplM7EgQ9J749GhKW P2Bo4xyOJpjrye+j2oD7mKohBaFl46yeWfu/6fTrIytXRGA6NpbM3Z/XRR/PMuG0n1AoQUDKZjH 8UliO6zN+WcCL+DVRfG8NVbDwUEsdWaXn5cy9cFh9FfxrGrozw4bGkHb6b8U5X953pHWUreMjPG 6RDf68g0k0L1Mcaw6ldj8smo7bjZDSZ/Kh/qAM1ZB26FQi1YMIAS1Re1m4oxI8zEvfFVScOCQg8 eFCRbkT9pvGvFqE+jTj4cZmH0x//wGgb4m1K8m5A7AG5UV/h5zhQTMxjoDKRT6FTdRG/GmC6Cay bZ0zcjsMk9TKUkrLC X-Google-Smtp-Source: AGHT+IHqu8khKPmdrz5ZxNhApg6woYn1wpjz3geiCjpfYxV9ENASu0IFRk3+3jTmUaVHH2l595zxFg== X-Received: by 2002:a17:903:46d0:b0:224:160d:3f54 with SMTP id d9443c01a7336-22780da858bmr63728105ad.31.1742574998924; Fri, 21 Mar 2025 09:36:38 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22780f39772sm19205225ad.25.2025.03.21.09.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 09:36:38 -0700 (PDT) Date: Fri, 21 Mar 2025 09:36:34 -0700 From: Joe Damato To: Jens Axboe Cc: Christoph Hellwig , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, kuba@kernel.org, shuah@kernel.org, sdf@fomichev.me, mingo@redhat.com, arnd@arndb.de, brauner@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, jolsa@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile Message-ID: Mail-Followup-To: Joe Damato , Jens Axboe , Christoph Hellwig , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, kuba@kernel.org, shuah@kernel.org, sdf@fomichev.me, mingo@redhat.com, arnd@arndb.de, brauner@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, jolsa@kernel.org, linux-kselftest@vger.kernel.org References: <2d68bc91-c22c-4b48-a06d-fa9ec06dfb25@kernel.dk> <19e3056c-2f7b-4f41-9c40-98955c4a9ed3@kernel.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 21, 2025 at 05:14:59AM -0600, Jens Axboe wrote: > On 3/20/25 11:56 PM, Christoph Hellwig wrote: > >> I don't know the entire historical context, but I presume sendmsg > >> did that because there was no other mechanism at the time. > > > > At least aio had been around for about 15 years at the point, but > > networking folks tend to be pretty insular and reinvent things. > > Yep... > > >> It seems like Jens suggested that plumbing this through for splice > >> was a possibility, but sounds like you disagree. > > > > Yes, very strongly. > > And that is very much not what I suggested, fwiw. Your earlier message said: If the answer is "because splice", then it would seem saner to plumb up those bits only. Would be much simpler too... wherein I interpreted "plumb those bits" to mean plumbing the error queue notifications on TX completions. My sincere apologies that I misunderstood your prior message and/or misconstrued what you said -- it was not clear to me what you meant. It is clear to me now, though, that adding a flag to splice as previously proposed and extending sendfile based on the SO_ZEROCOPY sock flag being set are both unacceptable solutions. If you happen to have a suggestion of some piece of code that I should read (other than the iouring implementation) to inform how I might build an RFCv2, I would appreciate the pointer. Thanks for your time and energy, Joe