From: Joe Damato <jdamato@fastly.com>
To: Samiullah Khawaja <skhawaja@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S . Miller " <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
almasrymina@google.com, willemb@google.com,
mkarsten@uwaterloo.ca, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/4] net: Create separate gro_flush helper function
Date: Fri, 21 Mar 2025 10:16:10 -0700 [thread overview]
Message-ID: <Z92e2kCYXQ_RsrJh@LQ3V64L9R2> (raw)
In-Reply-To: <20250321021521.849856-3-skhawaja@google.com>
On Fri, Mar 21, 2025 at 02:15:19AM +0000, Samiullah Khawaja wrote:
> Move multiple copies of same code snippet doing `gro_flush` and
> `gro_normal_list` into a separate helper function.
>
> Signed-off-by: Samiullah Khawaja <skhawaja@google.com>
As mentioned in the previous review, I think this is missing a spot.
the instance in napi_complete_done was not addressed as suggested
previously.
Is there any particular reason why that feedback was not addressed
in this revision?
next prev parent reply other threads:[~2025-03-21 17:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 2:15 [PATCH net-next v4 0/4] Add support to do threaded napi busy poll Samiullah Khawaja
2025-03-21 2:15 ` [PATCH net-next v4 1/4] Add support to set napi threaded for individual napi Samiullah Khawaja
2025-03-21 17:10 ` Joe Damato
2025-03-25 14:51 ` Jakub Kicinski
2025-04-01 18:27 ` Jakub Kicinski
2025-04-14 17:16 ` Samiullah Khawaja
2025-03-25 14:52 ` Jakub Kicinski
2025-03-21 2:15 ` [PATCH net-next v4 2/4] net: Create separate gro_flush helper function Samiullah Khawaja
2025-03-21 17:16 ` Joe Damato [this message]
2025-03-27 16:42 ` Samiullah Khawaja
2025-03-21 2:15 ` [PATCH net-next v4 3/4] Extend napi threaded polling to allow kthread based busy polling Samiullah Khawaja
2025-03-21 17:39 ` Joe Damato
2025-03-27 16:39 ` Samiullah Khawaja
2025-03-21 2:15 ` [PATCH net-next v4 4/4] selftests: Add napi threaded busy poll test in `busy_poller` Samiullah Khawaja
2025-03-24 2:38 ` [PATCH net-next v4 0/4] Add support to do threaded napi busy poll Martin Karsten
2025-03-25 16:40 ` Samiullah Khawaja
2025-03-25 17:47 ` Martin Karsten
2025-03-26 20:34 ` Samiullah Khawaja
2025-03-26 21:22 ` Martin Karsten
2025-03-26 21:57 ` Stanislav Fomichev
2025-03-27 18:40 ` Joe Damato
2025-03-27 19:35 ` Samiullah Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z92e2kCYXQ_RsrJh@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).