From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 374BD230996 for ; Fri, 21 Mar 2025 20:30:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742589050; cv=none; b=bThN3cAAJl45Wjv93YJ/xa6sBWK8/HI8gzEQngi9alb2uPtvsKjdOg5lqabHnSaswL7NsH21skuL+x2hq6nQsAMwiKYz1mRtp88ame2C9AN3lI/oTCZkjbWmElhUwt6+2ileTOJGol5gaKOCkYLBFOv2dhQjVA8pGzo+I6Zfv7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742589050; c=relaxed/simple; bh=kufjJ7ROxUIeeWBTf87pHaUYN0P9yN6f9l3gagdcYI0=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LRXGjBZ+T8eja/6tA9EmVZOJFI6XYt3gW6V1B6afk2IxmJjRCpKTjvihsBHAB5IBk76uBScBfecincPzbiC4ytU8Nu8LZfffz78VhQgTYvX3PB0YZZUcrhOBKuYh7iymYQoWRd2kAVvubUe8i9jrSAFDQRVeegN5lccYU+26DjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=l5o0kxHw; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="l5o0kxHw" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2239c066347so58101795ad.2 for ; Fri, 21 Mar 2025 13:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1742589047; x=1743193847; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=R/gNIM+yOS6xUSJi/6mY04tkW5DVweXdgmtDBLblehc=; b=l5o0kxHwz56/APvSz0yxxES3DtKjkGRzP3aHJgNtqfsPTeXBNyJqn9VNgMK3W6VEgd C3QYN/SUg1QAF8O7bGci/PkW/6tvRBw+3iE/xpWr29FsLghzQGbm9S5Ud3iooTfeENXt V1W51rg8ZwyivdKhNuOGhhAQIyBNtmn8MsF/I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742589047; x=1743193847; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=R/gNIM+yOS6xUSJi/6mY04tkW5DVweXdgmtDBLblehc=; b=VHC5374p6PelT2HSeFKN9u0fr3DQqABdu/f078bxOyAXCU73zLGqPi1L+Q603BzbQe /sSvoaaowllWneUnjC2E0lnMzFRF/NDMXibESoBIb1YwHSI4ahvVCDT9DdJ1bZUg0axT cJUte9fNDF9AG/J4RjjLqockbsVesQsJD5TT3JRpGJRhCg1EyO+I5ilNONj9MMahaqF0 9RNOoQ/Q/jq2PYG5bq9GBsoKuB7SC9CSCiRsPkLYS39e2werqRqtW2eMX798yReDI0yn Wr6oQlvm23pOQbpEsRQGjqlXe0Zeo/oN39GhRuuoje1xk47rh9fY7xi3Qi8fB1LY63gF XqSA== X-Forwarded-Encrypted: i=1; AJvYcCWBtL4l/l6ncMFIDhdZoBnkR5VBYEAIA0IDViccGwLfgECkLeo0d2Fwkw0EF6MdtcrGQVrVbqY=@vger.kernel.org X-Gm-Message-State: AOJu0YzT5J8egZMmhpgkKnwztdKtGyE+3hIxHjwv7ZHehYbFxwQzvEu/ SrQTxj8I7hCSEDUQjB3/dmjDDVSvQtEno5Zy9PKzyaxFgf8PM2hxP592UXT5HAs= X-Gm-Gg: ASbGncvGITRHIUSbVgK7IR8KIT0agcASwHdv8Mc9WSsu4r7qHP2HPGKegYN99hIweEd t32dBHKcQYDFQ/K8KYzMOiZQdjvMyz/FTNjsUrX0p+9Vql4ygSVj3kJ4+ijR2w5LYGR7VRL7fqc YzIT37qFgTrsLrPUXEQF4XI3yK8Qu6t96B8hiAGxDvacBG8vEwzyPgCKbk5qawebUJ2gWnjxH6Q 0+7Zh4KWkRD7FzIfh6c3S6DiebPF9i6A0N9Zj2oVTGk1HQ9pNeYSnKp/GFd2bvdaugM1BVfPbyK 9dNISrf8k9g22KjFa4RvKt5pKwCvRfkACJhpMcSCiQHghExJ2ofsUf/h+J1JYEhX9K76rW/wJvS bnP0OiqiAY9VO8+6A X-Google-Smtp-Source: AGHT+IE/0vRvWUIrCU9TpLfmE4aooUPQeYEWA/MrsW2UXdaB42a9j/XwGhSTptf5SM5XxL22FRt0Ug== X-Received: by 2002:a17:903:41ce:b0:224:10b9:357a with SMTP id d9443c01a7336-22780e3fbabmr64649685ad.32.1742589047213; Fri, 21 Mar 2025 13:30:47 -0700 (PDT) Received: from LQ3V64L9R2 (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-227811b2aefsm21875045ad.109.2025.03.21.13.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 13:30:46 -0700 (PDT) Date: Fri, 21 Mar 2025 13:30:43 -0700 From: Joe Damato To: Jens Axboe , Christoph Hellwig , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, kuba@kernel.org, shuah@kernel.org, sdf@fomichev.me, mingo@redhat.com, arnd@arndb.de, brauner@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, jolsa@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile Message-ID: Mail-Followup-To: Joe Damato , Jens Axboe , Christoph Hellwig , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, kuba@kernel.org, shuah@kernel.org, sdf@fomichev.me, mingo@redhat.com, arnd@arndb.de, brauner@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, jolsa@kernel.org, linux-kselftest@vger.kernel.org References: <2d68bc91-c22c-4b48-a06d-fa9ec06dfb25@kernel.dk> <19e3056c-2f7b-4f41-9c40-98955c4a9ed3@kernel.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 21, 2025 at 09:36:34AM -0700, Joe Damato wrote: > On Fri, Mar 21, 2025 at 05:14:59AM -0600, Jens Axboe wrote: > > On 3/20/25 11:56 PM, Christoph Hellwig wrote: > > >> I don't know the entire historical context, but I presume sendmsg > > >> did that because there was no other mechanism at the time. > > > > > > At least aio had been around for about 15 years at the point, but > > > networking folks tend to be pretty insular and reinvent things. > > > > Yep... > > > > >> It seems like Jens suggested that plumbing this through for splice > > >> was a possibility, but sounds like you disagree. > > > > > > Yes, very strongly. > > > > And that is very much not what I suggested, fwiw. > > Your earlier message said: > > If the answer is "because splice", then it would seem saner to > plumb up those bits only. Would be much simpler too... > > wherein I interpreted "plumb those bits" to mean plumbing the error > queue notifications on TX completions. > > My sincere apologies that I misunderstood your prior message and/or > misconstrued what you said -- it was not clear to me what you meant. I think what added to my confusion here was this bit, Jens: > > As far as the bit about plumbing only the splice bits, sorry if I'm > > being dense here, do you mean plumbing the error queue through to > > splice only and dropping sendfile2? > > > > That is an option. Then the apps currently using sendfile could use > > splice instead and get completion notifications on the error queue. > > That would probably work and be less work than rewriting to use > > iouring, but probably a bit more work than using a new syscall. > > Yep I thought I was explicitly asking if adding SPLICE_F_ZC and plumbing through the error queue notifications was OK and your response here ("Yep") suggested to me that it would be a suitable path to consider. I take it from your other responses, though, that I was mistaken.