From: Michal Kubiak <michal.kubiak@intel.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Masahisa Kojima <kojima.masahisa@socionext.com>,
Sunil Goutham <sgoutham@marvell.com>,
"Geetha sowjanya" <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-hyperv@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH net-next 0/7] net: xdp: Add missing metadata support for some xdp drvs
Date: Tue, 11 Mar 2025 16:35:16 +0100 [thread overview]
Message-ID: <Z9BYNBaAGZbtbfa4@localhost.localdomain> (raw)
In-Reply-To: <20250311-mvneta-xdp-meta-v1-0-36cf1c99790e@kernel.org>
On Tue, Mar 11, 2025 at 01:18:32PM +0100, Lorenzo Bianconi wrote:
> Introduce missing metadata support for some xdp drivers setting metadata
> size building the skb from xdp_buff.
> Please note most of the drivers are just compile tested.
>
> ---
> Lorenzo Bianconi (7):
> net: mvneta: Add metadata support for xdp mode
> net: mvpp2: Add metadata support for xdp mode
> net: netsec: Add metadata support for xdp mode
> net: octeontx2: Add metadata support for xdp mode
> net: ethernet: mediatek: Add metadata support for xdp mode
> net: mana: Add metadata support for xdp mode
> net: ti: cpsw: Add metadata support for xdp mode
>
> drivers/net/ethernet/marvell/mvneta.c | 5 ++++-
> drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 8 ++++++--
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c | 13 +++++++++----
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 7 +++++--
> drivers/net/ethernet/microsoft/mana/mana_bpf.c | 2 +-
> drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++++
> drivers/net/ethernet/socionext/netsec.c | 7 +++++--
> drivers/net/ethernet/ti/cpsw.c | 6 +++++-
> drivers/net/ethernet/ti/cpsw_new.c | 6 +++++-
> 9 files changed, 44 insertions(+), 14 deletions(-)
> ---
> base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe
> change-id: 20250310-mvneta-xdp-meta-3e0da8ef4498
>
> Best regards,
> --
> Lorenzo Bianconi <lorenzo@kernel.org>
>
>
As far as I checked, all modified drivers use the Page Pool and set the XDP
headroom. So, a necessary space for metadata seems to be assured for all
of the drivers.
In summary, the series looks OK.
Thanks,
Michal
For the series:
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
next prev parent reply other threads:[~2025-03-11 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 12:18 [PATCH net-next 0/7] net: xdp: Add missing metadata support for some xdp drvs Lorenzo Bianconi
2025-03-11 12:18 ` [PATCH net-next 1/7] net: mvneta: Add metadata support for xdp mode Lorenzo Bianconi
2025-03-11 12:18 ` [PATCH net-next 2/7] net: mvpp2: " Lorenzo Bianconi
2025-03-11 12:18 ` [PATCH net-next 3/7] net: netsec: " Lorenzo Bianconi
2025-03-14 12:00 ` Ilias Apalodimas
2025-03-11 12:18 ` [PATCH net-next 4/7] net: octeontx2: " Lorenzo Bianconi
2025-03-11 12:18 ` [PATCH net-next 5/7] net: ethernet: mediatek: " Lorenzo Bianconi
2025-03-11 12:18 ` [PATCH net-next 6/7] net: mana: " Lorenzo Bianconi
2025-03-11 12:18 ` [PATCH net-next 7/7] net: ti: cpsw: " Lorenzo Bianconi
2025-03-11 15:35 ` Michal Kubiak [this message]
2025-03-18 10:13 ` [PATCH net-next 0/7] net: xdp: Add missing metadata support for some xdp drvs Paolo Abeni
2025-03-18 11:06 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9BYNBaAGZbtbfa4@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ast@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=haiyangz@microsoft.com \
--cc=hawk@kernel.org \
--cc=hkelam@marvell.com \
--cc=ilias.apalodimas@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kojima.masahisa@socionext.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=marcin.s.wojtas@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=sbhatta@marvell.com \
--cc=sean.wang@mediatek.com \
--cc=sgoutham@marvell.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).