From: Stanislav Fomichev <stfomichev@gmail.com>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Gal Pressman <gal@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Yael Chemla <ychemla@nvidia.com>
Subject: Re: [PATCH net-next 4/4] net/mlx5e: Expose port reset cycle recovery counter via ethtool
Date: Fri, 14 Mar 2025 07:31:28 -0700 [thread overview]
Message-ID: <Z9Q9wBuDYHvEc4zY@mini-arch> (raw)
In-Reply-To: <1741893886-188294-5-git-send-email-tariqt@nvidia.com>
On 03/13, Tariq Toukan wrote:
> From: Yael Chemla <ychemla@nvidia.com>
>
> Display recovery event of PPCNT recovery counters group. Counts (per
> link) the number of total successful recovery events of any recovery
> types during port reset cycle.
>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
> .../ethernet/mellanox/mlx5/counters.rst | 5 +++
> .../ethernet/mellanox/mlx5/core/en_stats.c | 44 ++++++++++++++++---
> .../ethernet/mellanox/mlx5/core/en_stats.h | 4 ++
> 3 files changed, 48 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> index 99d95be4d159..f9a1cf370b5a 100644
> --- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> +++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> @@ -1082,6 +1082,11 @@ like flow control, FEC and more.
> need to replace the cable/transceiver.
> - Error
>
> + * - `total_success_recovery_phy`
> + - The number of total successful recovery events of any type during
> + ports reset cycle.
> + - Error
> +
html build complains with the following:
Sphinx parallel build error:
docutils.utils.SystemMessagePropagation: <system_message level="3" line="896" source="/home/doc-build/testing/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst" type="ERROR"><paragraph>Error parsing content block for the "flat-table" directive: exactly one bullet list expected.</paragraph><literal_block xml:space="preserve">.. flat-table:: Physical Port Counter Table
https://netdev-3.bots.linux.dev/doc-build/results/32382/stderr
The indent is wrong?
* - xx
- xx
- xx
Vs yours:
* - xx
- xx
- xx
---
pw-bot: cr
next prev parent reply other threads:[~2025-03-14 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 19:24 [PATCH net-next 0/4] mlx5e: Support recovery counter in reset Tariq Toukan
2025-03-13 19:24 ` [PATCH net-next 1/4] net/mlx5e: Ensure each counter group uses its PCAM bit Tariq Toukan
2025-03-14 2:40 ` Kalesh Anakkur Purayil
2025-03-13 19:24 ` [PATCH net-next 2/4] net/mlx5e: Access PHY layer counter group as other counter groups Tariq Toukan
2025-03-13 19:24 ` [PATCH net-next 3/4] net/mlx5e: Get counter group size by FW capability Tariq Toukan
2025-03-14 2:37 ` Kalesh Anakkur Purayil
2025-03-13 19:24 ` [PATCH net-next 4/4] net/mlx5e: Expose port reset cycle recovery counter via ethtool Tariq Toukan
2025-03-14 14:31 ` Stanislav Fomichev [this message]
2025-03-13 22:38 ` [PATCH net-next 0/4] mlx5e: Support recovery counter in reset Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Q9wBuDYHvEc4zY@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ychemla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).