From: Joe Damato <jdamato@fastly.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next 2/4] af_unix: Move internal definitions to net/unix/.
Date: Tue, 18 Mar 2025 16:12:32 -0700 [thread overview]
Message-ID: <Z9n94NKtHlDtFF0N@LQ3V64L9R2> (raw)
In-Reply-To: <20250318034934.86708-3-kuniyu@amazon.com>
On Mon, Mar 17, 2025 at 08:48:49PM -0700, Kuniyuki Iwashima wrote:
> net/af_unix.h is included by core and some LSMs, but most definitions
> need not be.
>
> Let's move struct unix_{vertex,edge} to net/unix/garbage.c and other
> definitions to net/unix/af_unix.h.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
> include/net/af_unix.h | 76 +-------------------------------------
> net/unix/af_unix.c | 2 +
> net/unix/af_unix.h | 75 +++++++++++++++++++++++++++++++++++++
> net/unix/diag.c | 2 +
> net/unix/garbage.c | 18 +++++++++
> net/unix/sysctl_net_unix.c | 2 +
> net/unix/unix_bpf.c | 2 +
> 7 files changed, 102 insertions(+), 75 deletions(-)
> create mode 100644 net/unix/af_unix.h
Nice clean up.
Reviewed-by: Joe Damato <jdamato@fastly.com>
next prev parent reply other threads:[~2025-03-18 23:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 3:48 [PATCH v1 net-next 0/4] af_unix: Clean up headers Kuniyuki Iwashima
2025-03-18 3:48 ` [PATCH v1 net-next 1/4] af_unix: Sort headers Kuniyuki Iwashima
2025-03-18 23:07 ` Joe Damato
2025-03-18 23:50 ` Kuniyuki Iwashima
2025-03-19 15:56 ` Joe Damato
2025-03-18 3:48 ` [PATCH v1 net-next 2/4] af_unix: Move internal definitions to net/unix/ Kuniyuki Iwashima
2025-03-18 23:12 ` Joe Damato [this message]
2025-03-19 17:49 ` Willem de Bruijn
2025-03-19 18:15 ` Kuniyuki Iwashima
2025-03-19 19:48 ` Willem de Bruijn
2025-03-18 3:48 ` [PATCH v1 net-next 3/4] af_unix: Explicitly include headers for non-pointer struct fields Kuniyuki Iwashima
2025-03-18 3:48 ` [PATCH v1 net-next 4/4] af_unix: Clean up #include under net/unix/ Kuniyuki Iwashima
2025-03-25 11:40 ` [PATCH v1 net-next 0/4] af_unix: Clean up headers patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9n94NKtHlDtFF0N@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox