From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts
Date: Wed, 19 Mar 2025 18:16:29 +0200 [thread overview]
Message-ID: <Z9rt3eHM6wdN-Yzg@smile.fi.intel.com> (raw)
In-Reply-To: <Z9rm6NYEQpbo4-pz@shell.armlinux.org.uk>
On Wed, Mar 19, 2025 at 03:46:48PM +0000, Russell King (Oracle) wrote:
> On Wed, Mar 19, 2025 at 12:54:33PM +0200, Andy Shevchenko wrote:
...
> > -#define PHY_ID_FMT "%s:%02x"
> > +#define PHY_ID_FMT "%s:%02hhx"
>
> I was going to state whether it is correct to use hh with an "int"
> argument, as printf() suggests its only for use with arguments of
> type 'signed char' and 'unsigned char'. My suspicion has been
Yeah...
> It seems this is not a correct fix for the problem you report.
Apparently looks like (from the clang point of view — I compiled it with GCC).
...
Thanks for the review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-19 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 10:54 [PATCH net v2 0/2] net: phy: Fix potential string cut when using PHY_ID_FMT Andy Shevchenko
2025-03-19 10:54 ` [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts Andy Shevchenko
2025-03-19 11:21 ` Andy Shevchenko
2025-03-19 15:37 ` kernel test robot
2025-03-19 15:52 ` Andy Shevchenko
2025-03-19 15:46 ` Russell King (Oracle)
2025-03-19 16:16 ` Andy Shevchenko [this message]
2025-03-19 17:27 ` kernel test robot
2025-03-19 10:54 ` [PATCH net v2 2/2] net: usb: asix: ax88772: Increase phy_name size Andy Shevchenko
2025-03-19 11:26 ` Andy Shevchenko
2025-03-19 14:43 ` Russell King (Oracle)
2025-03-19 16:22 ` Andy Shevchenko
2025-03-19 17:13 ` Russell King (Oracle)
2025-03-19 18:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9rt3eHM6wdN-Yzg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).