From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB56C6FD19 for ; Mon, 13 Mar 2023 11:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbjCMLQn (ORCPT ); Mon, 13 Mar 2023 07:16:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjCMLQ0 (ORCPT ); Mon, 13 Mar 2023 07:16:26 -0400 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5DD64850; Mon, 13 Mar 2023 04:15:36 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=tonylu@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VdmUiz9_1678706118; Received: from localhost(mailfrom:tonylu@linux.alibaba.com fp:SMTPD_---0VdmUiz9_1678706118) by smtp.aliyun-inc.com; Mon, 13 Mar 2023 19:15:18 +0800 Date: Mon, 13 Mar 2023 19:15:17 +0800 From: Tony Lu To: Wenjia Zhang Cc: David Miller , Jakub Kicinski , netdev@vger.kernel.org, linux-s390@vger.kernel.org, Eric Dumazet , Paolo Abeni , Heiko Carstens , Karsten Graul , Alexandra Winter , Jan Karcher , Stefan Raspl , Alexander Gordeev Subject: Re: [PATCH net 2/2] net/smc: Fix device de-init sequence Message-ID: Reply-To: Tony Lu References: <20230313100829.13136-1-wenjia@linux.ibm.com> <20230313100829.13136-3-wenjia@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230313100829.13136-3-wenjia@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 13, 2023 at 11:08:29AM +0100, Wenjia Zhang wrote: > From: Stefan Raspl > > CLC message initialization was not properly reversed in error handling path. > > Reported-and-suggested-by: Alexander Gordeev > Signed-off-by: Stefan Raspl > Signed-off-by: Wenjia Zhang Reviewed-by: Tony Lu Thanks, LGTM. > --- > net/smc/af_smc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c > index a4cccdfdc00a..50052f53a1dd 100644 > --- a/net/smc/af_smc.c > +++ b/net/smc/af_smc.c > @@ -3498,6 +3498,7 @@ static int __init smc_init(void) > out_nl: > smc_nl_exit(); > out_ism: > + smc_clc_exit(); > smc_ism_exit(); > out_pernet_subsys_stat: > unregister_pernet_subsys(&smc_net_stat_ops); > -- > 2.37.2