From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29370C6FD1F for ; Mon, 13 Mar 2023 16:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231451AbjCMQsK (ORCPT ); Mon, 13 Mar 2023 12:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbjCMQsA (ORCPT ); Mon, 13 Mar 2023 12:48:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D43D98A56; Mon, 13 Mar 2023 09:47:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 39615B81150; Mon, 13 Mar 2023 16:47:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42BFFC433AE; Mon, 13 Mar 2023 16:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678726073; bh=O0k8dCmgNKsBDzjXFjjwe97dKJxvw+naBwBLaX7J2hs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dEUlkiUR/Y66YdOSgGsg+sdH1voBSfomApHILq5vwIRkwzRM8Pw38qS3pHiqupBT9 yE0HHPgvAJTbdKPhP+cv2FMZDI/sceZwJSZl1aum4b1MbLL4x1t2m+uH/1rJSNKsvr XyQq4lKgyQeiMO5mbWSvRP9pDgcH0HvcWNeERD/gRtaSXQPPYuSmPSWioD8C/gq8t3 bSlWKg0KJuBx4XOW0bSIccqvK5PKSQW0UhPrm1L2GYccznclWmoUkrFF3U5lGZv8Yi 5cTaMfcHclFehxl8Jyy8f8oXWKvdcAqZjIXmJtKpz+kG8KU7oG1lwwuFgWtKKoWhZ7 /4aBd05n+ZscA== Date: Mon, 13 Mar 2023 17:47:49 +0100 From: Lorenzo Bianconi To: Eric Dumazet Cc: Matthieu Baerts , netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, saeedm@nvidia.com, leon@kernel.org, shayagr@amazon.com, akiyano@amazon.com, darinzon@amazon.com, sgoutham@marvell.com, lorenzo.bianconi@redhat.com, toke@redhat.com, teknoraver@meta.com, ttoukan.linux@gmail.com Subject: Re: [PATCH net v2 6/8] veth: take into account device reconfiguration for xdp_features flag Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ERSyJMPtEtDms7QR" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --ERSyJMPtEtDms7QR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Mon, Mar 13, 2023 at 9:36=E2=80=AFAM Lorenzo Bianconi wrote: > > > > > On Mon, Mar 13, 2023 at 8:50=E2=80=AFAM Eric Dumazet wrote: > > > > > > > > On Mon, Mar 13, 2023 at 7:15=E2=80=AFAM Matthieu Baerts > > > > wrote: > > > > > > > > > > Hi Lorenzo, > > > > > > > > > > On 09/03/2023 13:25, Lorenzo Bianconi wrote: > > > > > > Take into account tx/rx queues reconfiguration setting device > > > > > > xdp_features flag. Moreover consider NETIF_F_GRO flag in order = to enable > > > > > > ndo_xdp_xmit callback. > > > > > > > > > > > > Fixes: 66c0e13ad236 ("drivers: net: turn on XDP features") > > > > > > Signed-off-by: Lorenzo Bianconi > > > > > > > > > > Thank you for the modification. > > > > > > > > > > Unfortunately, 'git bisect' just told me this modification is the= origin > > > > > of a new WARN when using veth in a netns: > > > > > > > > > > > > > > > ###################### 8< ###################### > > > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > > > > WARNING: suspicious RCU usage > > > > > 6.3.0-rc1-00144-g064d70527aaa #149 Not tainted > > > > > ----------------------------- > > > > > drivers/net/veth.c:1265 suspicious rcu_dereference_check() usage! > > > > > > > > > > other info that might help us debug this: > > > > > > > > > > > > > Same observation here, I am releasing a syzbot report with a repro. > > > > > > > > > > > > > > I guess a fix would be: > > > > > > > Acked-by: Lorenzo Bianconi >=20 > Can you submit a formal fix ? ack, will do. Regards, Lorenzo >=20 > Thanks. --ERSyJMPtEtDms7QR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZA9TtQAKCRA6cBh0uS2t rLxmAQDqU9+1YtSH9qB4uwPQKIRA4ig0qjQkBotaVjxtEno7OAEAg7d0NSwerNjh vq9Af4+3csM0fA/EeIY6OvkYfa9ltgo= =m2VX -----END PGP SIGNATURE----- --ERSyJMPtEtDms7QR--