From: Simon Horman <simon.horman@corigine.com>
To: Josef Miegl <josef@miegl.cz>
Cc: Eyal Birger <eyal.birger@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: geneve: set IFF_POINTOPOINT with IFLA_GENEVE_INNER_PROTO_INHERIT
Date: Mon, 13 Mar 2023 19:42:48 +0100 [thread overview]
Message-ID: <ZA9uqAPhmUyYPcdo@corigine.com> (raw)
In-Reply-To: <20230312164557.55354-1-josef@miegl.cz>
On Sun, Mar 12, 2023 at 05:45:57PM +0100, Josef Miegl wrote:
> The GENEVE tunnel used with IFLA_GENEVE_INNER_PROTO_INHERIT is
> point-to-point, so set IFF_POINTOPOINT to reflect that.
>
> Signed-off-by: Josef Miegl <josef@miegl.cz>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/net/geneve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 32684e94eb4f..78f9d588f712 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -1421,7 +1421,7 @@ static int geneve_configure(struct net *net, struct net_device *dev,
> dev->type = ARPHRD_NONE;
> dev->hard_header_len = 0;
> dev->addr_len = 0;
> - dev->flags = IFF_NOARP;
> + dev->flags = IFF_POINTOPOINT | IFF_NOARP;
> }
>
> err = register_netdevice(dev);
> --
> 2.37.1
>
next prev parent reply other threads:[~2023-03-13 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 16:45 [PATCH net-next] net: geneve: set IFF_POINTOPOINT with IFLA_GENEVE_INNER_PROTO_INHERIT Josef Miegl
2023-03-13 18:42 ` Simon Horman [this message]
2023-03-15 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA9uqAPhmUyYPcdo@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=josef@miegl.cz \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).