From: Maxim Mikityanskiy <maxtram95@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Adrien Moulin <amoulin@corp.free.fr>,
borisp@nvidia.com, john.fastabend@gmail.com, tariqt@nvidia.com,
maximmi@nvidia.com
Subject: Re: [PATCH net] net: tls: fix device-offloaded sendpage straddling records
Date: Mon, 6 Mar 2023 11:07:20 +0200 [thread overview]
Message-ID: <ZAWtE34EJw79Oqkx@mail.gmail.com> (raw)
In-Reply-To: <20230304192610.3818098-1-kuba@kernel.org>
On Sat, Mar 04, 2023 at 11:26:10AM -0800, Jakub Kicinski wrote:
> Adrien reports that incorrect data is transmitted when a single
> page straddles multiple records. We would transmit the same
> data in all iterations of the loop.
>
> Reported-by: Adrien Moulin <amoulin@corp.free.fr>
> Link: https://lore.kernel.org/all/61481278.42813558.1677845235112.JavaMail.zimbra@corp.free.fr
> Fixes: c1318b39c7d3 ("tls: Add opt-in zerocopy mode of sendfile()")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
Thanks for the fix, looks good to me.
Acked-by: Maxim Mikityanskiy <maxtram95@gmail.com>
> Maxim, can I add a .mailmap entry for you? get_maintainers
> will complain if I don't CC your @nvidia address :(
Yes please, that would be great. You can also add maximmi@mellanox.com,
in case someone refers to some old commit.
next prev parent reply other threads:[~2023-03-06 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 19:26 [PATCH net] net: tls: fix device-offloaded sendpage straddling records Jakub Kicinski
2023-03-04 19:55 ` Adrien Moulin
2023-03-06 7:19 ` Tariq Toukan
2023-03-06 9:07 ` Maxim Mikityanskiy [this message]
2023-03-06 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAWtE34EJw79Oqkx@mail.gmail.com \
--to=maxtram95@gmail.com \
--cc=amoulin@corp.free.fr \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).