From: Simon Horman <simon.horman@corigine.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jaewan Kim <jaewan@google.com>,
gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-team@android.com,
adelva@google.com
Subject: Re: [PATCH v8 3/5] mac80211_hwsim: add PMSR request support via virtio
Date: Mon, 6 Mar 2023 22:11:25 +0100 [thread overview]
Message-ID: <ZAZW/VAIESfTgByW@corigine.com> (raw)
In-Reply-To: <582bea54cc5833137a2f8b7a375484b1656ed761.camel@sipsolutions.net>
On Mon, Mar 06, 2023 at 09:45:16PM +0100, Johannes Berg wrote:
> On Mon, 2023-03-06 at 18:12 +0100, Simon Horman wrote:
> >
> > >
> > > +static int mac80211_hwsim_send_pmsr_ftm_request_peer(struct sk_buff *msg,
> > > + struct cfg80211_pmsr_ftm_request_peer *request)
> > > +{
> > > + struct nlattr *ftm;
> > > +
> > > + if (!request->requested)
> > > + return -EINVAL;
> > > +
> > > + ftm = nla_nest_start(msg, NL80211_PMSR_TYPE_FTM);
> > > + if (!ftm)
> > > + return -ENOBUFS;
> > > +
> > > + if (nla_put_u32(msg, NL80211_PMSR_FTM_REQ_ATTR_PREAMBLE, request->preamble))
> >
> > nit: I suspect that you need to invoke nla_nest_cancel() in
> > error paths to unwind nla_nest_start() calls.
>
> The entire message is discarded if that happens, I think? Doesn't seem
> all that necessary in that case.
Thanks. I was wondering about that, but forgot to add it to my review message.
next prev parent reply other threads:[~2023-03-06 21:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 16:03 [PATCH v8 0/5] mac80211_hwsim: Add PMSR support Jaewan Kim
2023-03-02 16:03 ` [PATCH v8 1/5] mac80211_hwsim: add PMSR capability support Jaewan Kim
2023-03-06 16:54 ` Simon Horman
2023-03-06 16:58 ` Johannes Berg
2023-03-06 17:38 ` Simon Horman
2023-03-08 8:00 ` Jaewan Kim
2023-03-08 8:06 ` Johannes Berg
2023-03-13 7:54 ` Jaewan Kim
2023-03-02 16:03 ` [PATCH v8 2/5] wifi: nl80211: make nl80211_send_chandef non-static Jaewan Kim
2023-03-02 16:03 ` [PATCH v8 3/5] mac80211_hwsim: add PMSR request support via virtio Jaewan Kim
2023-03-06 17:12 ` Simon Horman
2023-03-06 17:43 ` Simon Horman
2023-03-06 20:45 ` Johannes Berg
2023-03-06 21:11 ` Simon Horman [this message]
2023-03-02 16:03 ` [PATCH v8 4/5] mac80211_hwsim: add PMSR abort " Jaewan Kim
2023-03-06 17:37 ` Simon Horman
2023-03-07 6:56 ` Simon Horman
2023-03-02 16:03 ` [PATCH v8 5/5] mac80211_hwsim: add PMSR report " Jaewan Kim
2023-03-02 17:42 ` [PATCH v8 0/5] mac80211_hwsim: Add PMSR support Greg KH
2023-03-06 9:42 ` Kalle Valo
[not found] ` <CABZjns4xYjcn4CQzEoiozz9j7mKF0py0WE+AZ2Koi9Vz3khVLQ@mail.gmail.com>
2023-03-08 10:05 ` Kalle Valo
2023-03-13 7:56 ` Jaewan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAZW/VAIESfTgByW@corigine.com \
--to=simon.horman@corigine.com \
--cc=adelva@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaewan@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-team@android.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).