From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B649EC6FA99 for ; Tue, 7 Mar 2023 12:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbjCGMBr (ORCPT ); Tue, 7 Mar 2023 07:01:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbjCGMBp (ORCPT ); Tue, 7 Mar 2023 07:01:45 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 556D232530 for ; Tue, 7 Mar 2023 04:01:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/DdiJJW2KMfOiNRsqXeyzvsPa+tiQ685iR7M7gsvOIw=; b=R2Qb1TE8dqEBMGg7VF0Dpe19ee hwjqzoiTKKi07io0ZMqiVYyM5u9bzjnQQTVVoSzx9jZ65pIh40pUSAT0gKdLJxqle8PKE1orcHzsy F3KgegTzmjJhVakafY4SuCJioqn0+3aevIpZN87oxB9nTRFIANxkHKYggDcz7niX4UxmA+fImIsvI 7eXgUBImPC62skToo1ycHrXW2WkdpF3zU2gPzWKFGoUYMmbihzmKImoxY7/D00OvEe+dFn2aVGaA4 h/Z8fBdrklVOc+qizDVNHSWSVOrK2wvj+3OEagH8vXQuVoskHe/yRjdibMLMTVG6xGEHGJZwFd/Qi PVwF2npg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36490) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pZW0R-00007V-Bc; Tue, 07 Mar 2023 12:01:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pZW0L-0001Ub-7W; Tue, 07 Mar 2023 12:01:17 +0000 Date: Tue, 7 Mar 2023 12:01:17 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC net-next 4/4] net: mtk_eth_soc: note interface modes not set in supported_interfaces Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org To any of those with Mediatek hardware... Any opinions on what we should do concerning these modes? If I don't get a reply, then I'll delete these. There's no point having this code if it's been unreachable for a while and no one's complained. Thanks. On Fri, Feb 24, 2023 at 12:36:26PM +0000, Russell King (Oracle) wrote: > Signed-off-by: Russell King (Oracle) > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index f78810717f66..280490942fa4 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -530,9 +530,11 @@ static void mtk_mac_config(struct phylink_config *config, unsigned int mode, > case PHY_INTERFACE_MODE_GMII: > ge_mode = 1; > break; > + /* FIXME: RMII is not set in the phylink capabilities */ > case PHY_INTERFACE_MODE_REVMII: > ge_mode = 2; > break; > + /* FIXME: RMII is not set in the phylink capabilities */ > case PHY_INTERFACE_MODE_RMII: > if (mac->id) > goto err_phy; > -- > 2.30.2 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!