From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B418AC6FD1C for ; Wed, 8 Mar 2023 18:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbjCHSY4 (ORCPT ); Wed, 8 Mar 2023 13:24:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230128AbjCHSYy (ORCPT ); Wed, 8 Mar 2023 13:24:54 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B7B0BAD24 for ; Wed, 8 Mar 2023 10:24:52 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id i34so69364334eda.7 for ; Wed, 08 Mar 2023 10:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; t=1678299891; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=weUKc1gFk3YK76PmJbUQm2uDC+7qg68lF0YoPIdM38U=; b=WC6qhziTG+HUxsT0RVO+qgUmADvjBEzJ1Fpg7NtZSe0zHetqM7+WrP/pLwzsNkdAId MXezDcnorfkScBOMwHKZ2cL0HLFo1QUGnx6g2xcyBTcIOiG4jzWGzsL8LsHvn/ihTOXl N5oRsi4aEZcWcA+7wjkztAofPpew1mXKzsJfL7g31bhDiwaIXLNazuSXkcSfvYkDGv46 r4ezqi9NRWAN6VCgUdMO9/i9mkkQDvDgOj00I7EBG2bFxJFt7NkxtKN4kS//LqYS4XHO AwtOSuY574R8uaF9+aMfXG5mx6AfSEOlBB0PZY8p6k/5/4u2UjnATIr+qtX0YLg95pmD /b4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678299891; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=weUKc1gFk3YK76PmJbUQm2uDC+7qg68lF0YoPIdM38U=; b=LZr5vinOKhL2CoqER6MAB6ihPkAlN1LXMnwnVkngss90um8hCoAZuMhPzJd2uSpHeu lUKYKwj3CXX9A9yfRMNvUQKaDGoiRgTlvA4FIW2GMNR9U86ZufJUQ+Y6lRjIYEfvRFf9 q20E4+T1AIq9Z1v2qIHMLazviqivQrkhpS66eOmzov+AvJz5fbVIoeII/1v5ovl4NuZC HWHi68DUGhgTl4OCLrXKdCvNjacgevVpMFuXPoPyY0wBvoEIcvOmO4T5fvK70M64q+kz +wZGnZ2HE56+fIUYMplBvC+9M7wm1HhGxFiRYaNLAlkJVdGFpLULgXOxDZAudOfC36tt ASow== X-Gm-Message-State: AO0yUKWmQwr4goc8WPQqtcBhWMNw9wLYhzdIcoOuX7Y0lsbJS6sssCSR LcDBoPVf+gRDp7LHymTbI9qeTg== X-Google-Smtp-Source: AK7set9A1V50i8EcdZaJaGWkZIrp3PPjL/kaKhDvd7srdZZtoempWiehnOkDGgHadpOjyfOtqGmdig== X-Received: by 2002:a17:906:d9c8:b0:8e1:cc38:6ab0 with SMTP id qk8-20020a170906d9c800b008e1cc386ab0mr17046218ejb.16.1678299890625; Wed, 08 Mar 2023 10:24:50 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id l3-20020a1709067d4300b008e54ac90de1sm7752698ejp.74.2023.03.08.10.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 10:24:49 -0800 (PST) Date: Wed, 8 Mar 2023 19:24:48 +0100 From: Jiri Pirko To: Po-Hsu Lin Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, idosch@mellanox.com, danieller@mellanox.com, petrm@mellanox.com, shuah@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net Subject: Re: [PATCHv2] selftests: net: devlink_port_split.py: skip test if no suitable device available Message-ID: References: <20230307150030.527726-1-po-hsu.lin@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Mar 08, 2023 at 03:37:41PM CET, po-hsu.lin@canonical.com wrote: >On Wed, Mar 8, 2023 at 7:41 PM Jiri Pirko wrote: >> >> Wed, Mar 08, 2023 at 11:21:57AM CET, po-hsu.lin@canonical.com wrote: >> >On Wed, Mar 8, 2023 at 5:31 PM Jiri Pirko wrote: >> >> >> >> Tue, Mar 07, 2023 at 04:00:30PM CET, po-hsu.lin@canonical.com wrote: >> >> >The `devlink -j port show` command output may not contain the "flavour" >> >> >key, an example from s390x LPAR with Ubuntu 22.10 (5.19.0-37-generic), >> >> >iproute2-5.15.0: >> >> > {"port":{"pci/0001:00:00.0/1":{"type":"eth","netdev":"ens301"}, >> >> > "pci/0001:00:00.0/2":{"type":"eth","netdev":"ens301d1"}, >> >> > "pci/0002:00:00.0/1":{"type":"eth","netdev":"ens317"}, >> >> > "pci/0002:00:00.0/2":{"type":"eth","netdev":"ens317d1"}}} >> >> >> >> As Jakub wrote, this is odd. Could you debug if kernel sends the flavour >> >> attr and if not why? Also, could you try with most recent kernel? >> > >> >I did a quick check on another s390x LPAR instance which is running >> >with Ubuntu 23.04 (6.1.0-16-generic) iproute2-6.1.0, there is still no >> >"flavour" attribute. >> >$ devlink port show >> >pci/0001:00:00.0/1: type eth netdev ens301 >> >pci/0001:00:00.0/2: type eth netdev ens301d1 >> >pci/0002:00:00.0/1: type eth netdev ens317 >> >pci/0002:00:00.0/2: type eth netdev ens317d1 >> > >> >The behaviour didn't change with iproute2 built from source [1] >> >> Could you paste output of "devlink dev info"? >> Looks like something might be wrong in the kernel devlink/driver code. >> >The `devlink dev info` output is empty. The following output is from >that Ubuntu 23.04 s390x LPAR, run as root: ># devlink dev show >pci/0001:00:00.0 >pci/0002:00:00.0 ># devlink dev show pci/0001:00:00.0 >pci/0001:00:00.0 ># devlink dev info ># devlink dev info pci/0001:00:00.0 Interesting, could you try ethtool -i to get the driver name? >kernel answers: Operation not supported > >>