From: Simon Horman <simon.horman@corigine.com>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Tariq Toukan <tariqt@nvidia.com>,
Larysa Zaremba <larysa.zaremba@intel.com>
Subject: Re: [PATCH net-next v2 2/2] skbuff: Add likely to skb pointer in build_skb()
Date: Thu, 9 Mar 2023 14:33:38 +0100 [thread overview]
Message-ID: <ZAngMiF+G9agDf+M@corigine.com> (raw)
In-Reply-To: <20230308131720.2103611-3-gal@nvidia.com>
On Wed, Mar 08, 2023 at 03:17:20PM +0200, Gal Pressman wrote:
> Similarly to napi_build_skb(), it is likely the skb allocation in
> build_skb() succeeded. frag_size != 0 is also likely, as stated in
> __build_skb_around().
>
> Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-09 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 13:17 [PATCH net-next v2 0/2] Couple of minor improvements to build_skb variants Gal Pressman
2023-03-08 13:17 ` [PATCH net-next v2 1/2] skbuff: Replace open-coded skb_propagate_pfmemalloc()s Gal Pressman
2023-03-09 13:33 ` Simon Horman
2023-03-08 13:17 ` [PATCH net-next v2 2/2] skbuff: Add likely to skb pointer in build_skb() Gal Pressman
2023-03-09 13:33 ` Simon Horman [this message]
2023-03-11 1:00 ` [PATCH net-next v2 0/2] Couple of minor improvements to build_skb variants patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAngMiF+G9agDf+M@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).