* [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h
@ 2023-03-09 22:52 Muhammad Usama Anjum
2023-03-10 14:28 ` Simon Horman
2023-03-11 5:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Muhammad Usama Anjum @ 2023-03-09 22:52 UTC (permalink / raw)
To: Ariel Elior, Manish Chopra, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Muhammad Usama Anjum, kernel, kernel-janitors, aleksander.lobakin,
simon.horman, netdev, linux-kernel
make versioncheck reports the following:
./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
So remove linux/version.h from both of these files. Also remove
linux/compiler.h while at it as it is also not being used.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
Changes since v2:
- Correct subject and check patch application on net-next
Changes since v1:
- Remove linux/compiler.h as well
---
drivers/net/ethernet/qlogic/qede/qede.h | 2 --
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index f90dcfe9ee68..f9931ecb7baa 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -6,8 +6,6 @@
#ifndef _QEDE_H_
#define _QEDE_H_
-#include <linux/compiler.h>
-#include <linux/version.h>
#include <linux/workqueue.h>
#include <linux/netdevice.h>
#include <linux/interrupt.h>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 8034d812d5a0..374a86b875a3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -4,7 +4,6 @@
* Copyright (c) 2019-2020 Marvell International Ltd.
*/
-#include <linux/version.h>
#include <linux/types.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h
2023-03-09 22:52 [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h Muhammad Usama Anjum
@ 2023-03-10 14:28 ` Simon Horman
2023-03-11 5:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-03-10 14:28 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: Ariel Elior, Manish Chopra, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, kernel, kernel-janitors,
aleksander.lobakin, netdev, linux-kernel
On Fri, Mar 10, 2023 at 03:52:05AM +0500, Muhammad Usama Anjum wrote:
> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>
> So remove linux/version.h from both of these files. Also remove
> linux/compiler.h while at it as it is also not being used.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h
2023-03-09 22:52 [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h Muhammad Usama Anjum
2023-03-10 14:28 ` Simon Horman
@ 2023-03-11 5:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-11 5:40 UTC (permalink / raw)
To: Muhammad Usama Anjum
Cc: aelior, manishc, davem, edumazet, kuba, pabeni, kernel,
kernel-janitors, aleksander.lobakin, simon.horman, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 10 Mar 2023 03:52:05 +0500 you wrote:
> make versioncheck reports the following:
> ./drivers/net/ethernet/qlogic/qede/qede.h: 10 linux/version.h not needed.
> ./drivers/net/ethernet/qlogic/qede/qede_ethtool.c: 7 linux/version.h not needed.
>
> So remove linux/version.h from both of these files. Also remove
> linux/compiler.h while at it as it is also not being used.
>
> [...]
Here is the summary with links:
- [net-next,v3] qede: remove linux/version.h and linux/compiler.h
https://git.kernel.org/netdev/net-next/c/95b744508d4d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-11 5:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09 22:52 [PATCH net-next v3] qede: remove linux/version.h and linux/compiler.h Muhammad Usama Anjum
2023-03-10 14:28 ` Simon Horman
2023-03-11 5:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).