From: Simon Horman <simon.horman@corigine.com>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next 2/3] net/sched: act_pedit: check static offsets a priori
Date: Fri, 10 Mar 2023 15:19:35 +0100 [thread overview]
Message-ID: <ZAs8d3017dkWbHnJ@corigine.com> (raw)
In-Reply-To: <20230309185158.310994-3-pctammela@mojatatu.com>
On Thu, Mar 09, 2023 at 03:51:57PM -0300, Pedro Tammela wrote:
> Static key offsets should always be on 32 bit boundaries. Validate them on
> create/update time for static offsets and move the datapath validation
> for runtime offsets only.
>
> iproute2 already errors out if a given offset and data size cannot be packed
> to a 32 bit boundary. This change will make sure users which create/update pedit
> instances directly via netlink also error out, instead of finding out
> when packets are traversing.
>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-03-10 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 18:51 [PATCH net-next 0/3] net/sched: act_pedit: minor improvements Pedro Tammela
2023-03-09 18:51 ` [PATCH net-next 1/3] net/sched: act_pedit: use extack in 'ex' parsing errors Pedro Tammela
2023-03-10 14:19 ` Simon Horman
2023-03-13 18:25 ` Pedro Tammela
2023-03-09 18:51 ` [PATCH net-next 2/3] net/sched: act_pedit: check static offsets a priori Pedro Tammela
2023-03-10 14:19 ` Simon Horman [this message]
2023-03-09 18:51 ` [PATCH net-next 3/3] net/sched: act_pedit: rate limit datapath messages Pedro Tammela
2023-03-10 14:21 ` Simon Horman
2023-03-13 18:24 ` Pedro Tammela
2023-03-14 15:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAs8d3017dkWbHnJ@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).