From: Simon Horman <simon.horman@corigine.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kurt Kanzenbach <kurt@linutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get()
Date: Fri, 10 Mar 2023 19:18:42 +0100 [thread overview]
Message-ID: <ZAt0gqmOifS65Z91@corigine.com> (raw)
In-Reply-To: <20230310163855.21757-1-andriy.shevchenko@linux.intel.com>
On Fri, Mar 10, 2023 at 06:38:55PM +0200, Andy Shevchenko wrote:
> LED core provides a helper to parse default state from firmware node.
> Use it instead of custom implementation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> v5: resent after v6.3-rc1 with proper net-next prefix
> drivers/net/dsa/hirschmann/hellcreek_ptp.c | 45 ++++++++++++----------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/net/dsa/hirschmann/hellcreek_ptp.c b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> index b28baab6d56a..793b2c296314 100644
> --- a/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> +++ b/drivers/net/dsa/hirschmann/hellcreek_ptp.c
> @@ -297,7 +297,8 @@ static enum led_brightness hellcreek_led_is_gm_get(struct led_classdev *ldev)
> static int hellcreek_led_setup(struct hellcreek *hellcreek)
> {
> struct device_node *leds, *led = NULL;
> - const char *label, *state;
> + enum led_default_state state;
> + const char *label;
> int ret = -EINVAL;
>
> of_node_get(hellcreek->dev->of_node);
> @@ -318,16 +319,17 @@ static int hellcreek_led_setup(struct hellcreek *hellcreek)
> ret = of_property_read_string(led, "label", &label);
> hellcreek->led_sync_good.name = ret ? "sync_good" : label;
>
> - ret = of_property_read_string(led, "default-state", &state);
> - if (!ret) {
> - if (!strcmp(state, "on"))
> - hellcreek->led_sync_good.brightness = 1;
> - else if (!strcmp(state, "off"))
> - hellcreek->led_sync_good.brightness = 0;
> - else if (!strcmp(state, "keep"))
> - hellcreek->led_sync_good.brightness =
> - hellcreek_get_brightness(hellcreek,
> - STATUS_OUT_SYNC_GOOD);
> + state = led_init_default_state_get(of_fwnode_handle(led));
> + switch (state) {
> + case LEDS_DEFSTATE_ON:
> + hellcreek->led_sync_good.brightness = 1;
> + break;
> + case LEDS_DEFSTATE_KEEP:
> + hellcreek->led_sync_good.brightness =
> + hellcreek_get_brightness(hellcreek, STATUS_OUT_SYNC_GOOD);
nit: I think < 80 columns wide is still preferred for network code
> + break;
> + default:
> + hellcreek->led_sync_good.brightness = 0;
> }
>
> hellcreek->led_sync_good.max_brightness = 1;
> @@ -344,16 +346,17 @@ static int hellcreek_led_setup(struct hellcreek *hellcreek)
> ret = of_property_read_string(led, "label", &label);
> hellcreek->led_is_gm.name = ret ? "is_gm" : label;
>
> - ret = of_property_read_string(led, "default-state", &state);
> - if (!ret) {
> - if (!strcmp(state, "on"))
> - hellcreek->led_is_gm.brightness = 1;
> - else if (!strcmp(state, "off"))
> - hellcreek->led_is_gm.brightness = 0;
> - else if (!strcmp(state, "keep"))
> - hellcreek->led_is_gm.brightness =
> - hellcreek_get_brightness(hellcreek,
> - STATUS_OUT_IS_GM);
> + state = led_init_default_state_get(of_fwnode_handle(led));
> + switch (state) {
> + case LEDS_DEFSTATE_ON:
> + hellcreek->led_is_gm.brightness = 1;
> + break;
> + case LEDS_DEFSTATE_KEEP:
> + hellcreek->led_is_gm.brightness =
> + hellcreek_get_brightness(hellcreek, STATUS_OUT_IS_GM);
> + break;
> + default:
> + hellcreek->led_is_gm.brightness = 0;
> }
This seems to duplicate the logic in the earlier hunk of this patch.
Could it be moved into a helper?
>
> hellcreek->led_is_gm.max_brightness = 1;
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-03-10 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 16:38 [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() Andy Shevchenko
2023-03-10 18:18 ` Simon Horman [this message]
2023-03-10 18:44 ` Andy Shevchenko
2023-03-10 20:06 ` Andy Shevchenko
2023-03-10 20:16 ` Simon Horman
2023-03-10 20:23 ` Andy Shevchenko
2023-03-10 20:17 ` Simon Horman
2023-03-11 2:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAt0gqmOifS65Z91@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).