From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463E1C6FD19 for ; Fri, 10 Mar 2023 18:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbjCJSoQ (ORCPT ); Fri, 10 Mar 2023 13:44:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbjCJSoO (ORCPT ); Fri, 10 Mar 2023 13:44:14 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DB4E123CD1; Fri, 10 Mar 2023 10:44:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678473851; x=1710009851; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4UnjfyA94w7k9y2k9qSpn2LQxXEIB43/q+hQC/kcjZg=; b=etRX8miTeSgq5T835vPDYRsnKh9EF47LdvlL5xvGUERUeVROzM0sftd9 ZS+NP6WGsZY8hQfxCP2jJX7XsYnHbrm4haeNft9FHze/P1KjeMPuSVHoY mFb2FfMJBem+VgYkhOJwHlBM0sx8SOzf3YlTbJnRcJa0UhS8zjnuz7tmK //qTfIlztw9iZbELU1m9y/EosxZk6y3JXeZn+vSNQKr3px31C8biZSgJC 27bUFyWZmHGg/7FwofS9MVaw1NAESHLX3x3ebwpdvaVXrLB2HXpz3c+8A U1AXk59pP3NoEj0w0lju2bnCU5m2AOFPII67puaM979pZ1s4Y7ilAtyNc g==; X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="401662447" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="401662447" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 10:44:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="821162397" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="821162397" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 10 Mar 2023 10:44:07 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pahin-0015TV-0N; Fri, 10 Mar 2023 20:44:05 +0200 Date: Fri, 10 Mar 2023 20:44:04 +0200 From: Andy Shevchenko To: Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Kanzenbach , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() Message-ID: References: <20230310163855.21757-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 10, 2023 at 07:18:42PM +0100, Simon Horman wrote: > On Fri, Mar 10, 2023 at 06:38:55PM +0200, Andy Shevchenko wrote: ... > > + hellcreek->led_sync_good.brightness = > > + hellcreek_get_brightness(hellcreek, STATUS_OUT_SYNC_GOOD); > > nit: I think < 80 columns wide is still preferred for network code I can do it if it's a strict rule here. ... > This seems to duplicate the logic in the earlier hunk of this patch. > Could it be moved into a helper? It's possible, but in a separate patch as it's out of scope of this one. Do you want to create a such? -- With Best Regards, Andy Shevchenko