* [PATCH] mac80211: minstrel_ht: remove unused n_supported variable
@ 2023-03-25 13:26 Tom Rix
2023-03-25 16:05 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-25 13:26 UTC (permalink / raw)
To: johannes, davem, edumazet, kuba, pabeni, nathan, ndesaulniers
Cc: linux-wireless, netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
net/mac80211/rc80211_minstrel_ht.c:1711:6: error: variable
'n_supported' set but not used [-Werror,-Wunused-but-set-variable]
int n_supported = 0;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
net/mac80211/rc80211_minstrel_ht.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index 762346598338..b34c80522047 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -1708,7 +1708,6 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
struct sta_info *sta_info;
bool ldpc, erp;
int use_vht;
- int n_supported = 0;
int ack_dur;
int stbc;
int i;
@@ -1791,8 +1790,6 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
continue;
mi->supported[i] = mcs->rx_mask[nss - 1];
- if (mi->supported[i])
- n_supported++;
continue;
}
@@ -1819,9 +1816,6 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
mi->supported[i] = minstrel_get_valid_vht_rates(bw, nss,
vht_cap->vht_mcs.tx_mcs_map);
-
- if (mi->supported[i])
- n_supported++;
}
sta_info = container_of(sta, struct sta_info, sta);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: minstrel_ht: remove unused n_supported variable
2023-03-25 13:26 [PATCH] mac80211: minstrel_ht: remove unused n_supported variable Tom Rix
@ 2023-03-25 16:05 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2023-03-25 16:05 UTC (permalink / raw)
To: Tom Rix
Cc: johannes, davem, edumazet, kuba, pabeni, nathan, ndesaulniers,
linux-wireless, netdev, linux-kernel, llvm
On Sat, Mar 25, 2023 at 09:26:10AM -0400, Tom Rix wrote:
> clang with W=1 reports
> net/mac80211/rc80211_minstrel_ht.c:1711:6: error: variable
> 'n_supported' set but not used [-Werror,-Wunused-but-set-variable]
> int n_supported = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-25 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-25 13:26 [PATCH] mac80211: minstrel_ht: remove unused n_supported variable Tom Rix
2023-03-25 16:05 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).