From: Andrea Claudi <aclaudi@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Davide Caratti <dcaratti@redhat.com>,
Pedro Tammela <pctammela@mojatatu.com>,
Marcelo Leitner <mleitner@redhat.com>,
Phil Sutter <psutter@redhat.com>
Subject: Re: [PATCH iproute2 1/2] Revert "tc: m_action: fix parsing of TCA_EXT_WARN_MSG"
Date: Tue, 14 Mar 2023 13:10:03 +0100 [thread overview]
Message-ID: <ZBBkG3v5K7IEz/zo@renaissance-vector> (raw)
In-Reply-To: <20230314070449.1533298-1-liuhangbin@gmail.com>
On Tue, Mar 14, 2023 at 03:04:49PM +0800, Hangbin Liu wrote:
> This reverts commit 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a.
>
> The TCA_EXT_WARN_MSG is not sit within the TCA_ACT_TAB hierarchy. It's
> belong to the TCA_MAX namespace. I will fix the issue in another patch.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> tc/m_action.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tc/m_action.c b/tc/m_action.c
> index 6c91af2c..0400132c 100644
> --- a/tc/m_action.c
> +++ b/tc/m_action.c
> @@ -586,7 +586,7 @@ int print_action(struct nlmsghdr *n, void *arg)
>
> open_json_object(NULL);
> tc_dump_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0, false);
> - print_ext_msg(&tb[TCA_ACT_TAB]);
> + print_ext_msg(tb);
> close_json_object();
>
> return 0;
> --
> 2.38.1
>
As this patchset misses the cover letter, this covers patch 2/2 as
well.
Reviewed-by: Andrea Claudi <aclaudi@redhat.com>
next prev parent reply other threads:[~2023-03-14 12:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 6:58 [PATCH net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action Hangbin Liu
2023-03-14 6:58 ` [PATCH net 1/2] Revert "net/sched: act_api: move TCA_EXT_WARN_MSG to the correct hierarchy" Hangbin Liu
2023-03-14 22:32 ` Jamal Hadi Salim
2023-03-14 6:58 ` [PATCH net 2/2] net/sched: act_api: add specific EXT_WARN_MSG for tc action Hangbin Liu
2023-03-14 22:35 ` Jamal Hadi Salim
2023-03-15 9:47 ` Hangbin Liu
2023-03-15 18:49 ` Jamal Hadi Salim
2023-03-16 3:33 ` Hangbin Liu
2023-03-16 9:39 ` Jamal Hadi Salim
2023-03-15 7:45 ` Jakub Kicinski
2023-03-15 9:39 ` Hangbin Liu
2023-03-15 18:47 ` Jamal Hadi Salim
2023-03-14 7:04 ` [PATCH iproute2 1/2] Revert "tc: m_action: fix parsing of TCA_EXT_WARN_MSG" Hangbin Liu
2023-03-14 12:10 ` Andrea Claudi [this message]
2023-03-15 7:46 ` Jakub Kicinski
2023-03-15 9:31 ` Hangbin Liu
2023-03-14 7:08 ` [PATCH iproute2 2/2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG by using different enum Hangbin Liu
2023-03-14 9:22 ` Davide Caratti
2023-03-14 9:20 ` [PATCH net 0/2] net/sched: fix parsing of TCA_EXT_WARN_MSG for tc action Davide Caratti
2023-03-14 10:15 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBBkG3v5K7IEz/zo@renaissance-vector \
--to=aclaudi@redhat.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=psutter@redhat.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).