Re: [PATCH 0/5] can: tcan4x5x: Introduce tcan4552/4553

[Michal Kubiak <michal.kubiak@intel.com>]

On Tue, Mar 14, 2023 at 04:11:56PM +0100, Markus Schneider-Pargmann wrote:
> Hi Marc and everyone,
> 
> This series introduces two new chips tcan-4552 and tcan-4553. The
> generic driver works in general but needs a few small changes. These are
> caused by the removal of wake and state pins.
> 
> I included two patches from the optimization series and will remove them
> from the optimization series. Hopefully it avoids conflicts and not
> polute the other series with tcan4552/4553 stuff.
> 
> Best,
> Markus
> 
> optimization series:
> https://lore.kernel.org/lkml/20221221152537.751564-1-msp@baylibre.com
> 
> Markus Schneider-Pargmann (5):
>   dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants
>   can: tcan4x5x: Remove reserved register 0x814 from writable table
>   can: tcan4x5x: Check size of mram configuration
>   can: tcan4x5x: Rename ID registers to match datasheet
>   can: tcan4x5x: Add support for tcan4552/4553
> 
>  .../devicetree/bindings/net/can/tcan4x5x.txt  |  11 +-
>  drivers/net/can/m_can/m_can.c                 |  16 +++
>  drivers/net/can/m_can/m_can.h                 |   1 +
>  drivers/net/can/m_can/tcan4x5x-core.c         | 122 ++++++++++++++----
>  drivers/net/can/m_can/tcan4x5x-regmap.c       |   1 -
>  5 files changed, 121 insertions(+), 30 deletions(-)
>

The logic and coding style looks OK to me, but CAN-specific stuff should
be reviewed by someone else.
Just one nitpick in the last patch.

Thanks,
Michal

For entire series:
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

> -- 
> 2.39.2
>