From: Simon Horman <simon.horman@corigine.com>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants
Date: Tue, 14 Mar 2023 17:13:06 +0100 [thread overview]
Message-ID: <ZBCdEr/W6ZHjqTEq@corigine.com> (raw)
In-Reply-To: <20230314151201.2317134-2-msp@baylibre.com>
On Tue, Mar 14, 2023 at 04:11:57PM +0100, Markus Schneider-Pargmann wrote:
> These two new chips do not have state or wake pins.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Not a requirement from my side,
but perhaps it would be worth converting this binding to yaml
at some point.
> ---
> .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> index e3501bfa22e9..38a2b5369b44 100644
> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller
> This file provides device node information for the TCAN4x5x interface contains.
>
> Required properties:
> - - compatible: "ti,tcan4x5x"
> + - compatible:
> + "ti,tcan4x5x" or
> + "ti,tcan4552" or
> + "ti,tcan4553"
> - reg: 0
> - #address-cells: 1
> - #size-cells: 0
> @@ -21,8 +24,10 @@ Optional properties:
> - reset-gpios: Hardwired output GPIO. If not defined then software
> reset.
> - device-state-gpios: Input GPIO that indicates if the device is in
> - a sleep state or if the device is active.
> - - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
> + a sleep state or if the device is active. Not
> + available with tcan4552/4553.
> + - device-wake-gpios: Wake up GPIO to wake up the TCAN device. Not
> + available with tcan4552/4553.
>
> Example:
> tcan4x5x: tcan4x5x@0 {
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-14 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:11 [PATCH 0/5] can: tcan4x5x: Introduce tcan4552/4553 Markus Schneider-Pargmann
2023-03-14 15:11 ` [PATCH 1/5] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Markus Schneider-Pargmann
2023-03-14 16:13 ` Simon Horman [this message]
2023-03-14 20:01 ` Krzysztof Kozlowski
2023-03-15 10:49 ` Markus Schneider-Pargmann
2023-03-15 11:29 ` Marc Kleine-Budde
2023-03-15 11:25 ` Marc Kleine-Budde
2023-03-15 13:14 ` Krzysztof Kozlowski
2023-03-15 15:58 ` Markus Schneider-Pargmann
2023-03-15 16:03 ` Simon Horman
2023-03-15 16:07 ` Krzysztof Kozlowski
2023-03-14 15:11 ` [PATCH 2/5] can: tcan4x5x: Remove reserved register 0x814 from writable table Markus Schneider-Pargmann
2023-03-14 15:11 ` [PATCH 3/5] can: tcan4x5x: Check size of mram configuration Markus Schneider-Pargmann
2023-03-14 15:12 ` [PATCH 4/5] can: tcan4x5x: Rename ID registers to match datasheet Markus Schneider-Pargmann
2023-03-14 15:12 ` [PATCH 5/5] can: tcan4x5x: Add support for tcan4552/4553 Markus Schneider-Pargmann
2023-03-14 16:22 ` Simon Horman
2023-03-15 10:41 ` Markus Schneider-Pargmann
2023-03-14 18:19 ` Michal Kubiak
2023-03-14 18:26 ` [PATCH 0/5] can: tcan4x5x: Introduce tcan4552/4553 Michal Kubiak
2023-03-15 10:44 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBCdEr/W6ZHjqTEq@corigine.com \
--to=simon.horman@corigine.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=msp@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).