netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Petr Machata <petrm@nvidia.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	mlxsw@nvidia.com
Subject: Re: [PATCH net-next 0/5] net: Extend address label support
Date: Tue, 14 Mar 2023 19:43:06 +0200	[thread overview]
Message-ID: <ZBCyKtdDBkkECB3I@shredder> (raw)
In-Reply-To: <87a60fs2kp.fsf@nvidia.com>

On Tue, Mar 14, 2023 at 10:44:00AM +0100, Petr Machata wrote:
> Like with the labels, address replacement messages with an explicit
> IFA_PROTO are not bounced, they just neglect to actually change the
> protocol. But it makes no sense to me that someone would issue address
> replacement with an explicit proto set which differs from the current
> one, but would still rely on the fact that the proto doesn't change...

Especially when replace does work with IPv6 addresses. Couple that with
the fact that it's a much newer attribute than the labels (added in
5.18) and that it has no support in iproute2, FRR, libnl etc, the
chances of such a change breaking anyone are slim to none...

  reply	other threads:[~2023-03-14 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 11:44 [PATCH net-next 0/5] net: Extend address label support Petr Machata
2023-03-10 11:44 ` [PATCH net-next 1/5] net: ipv4: Allow changing IPv4 labels Petr Machata
2023-03-10 11:44 ` [PATCH net-next 2/5] net: ipv6: addrconf: Support IPv6 address labels Petr Machata
2023-03-10 11:44 ` [PATCH net-next 3/5] net: ipv6: addrconf: Expose IPv6 address labels through netlink Petr Machata
2023-03-10 11:44 ` [PATCH net-next 4/5] selftests: rtnetlink: Make the set of tests to run configurable Petr Machata
2023-03-10 11:44 ` [PATCH net-next 5/5] selftests: rtnetlink: Add an address label test Petr Machata
2023-03-11  1:12 ` [PATCH net-next 0/5] net: Extend address label support Jakub Kicinski
2023-03-13 13:26   ` Petr Machata
2023-03-13 22:10     ` Jakub Kicinski
2023-03-14  9:44       ` Petr Machata
2023-03-14 17:43         ` Ido Schimmel [this message]
2023-03-15  4:37           ` Jakub Kicinski
2023-03-11  3:41 ` Stephen Hemminger
2023-03-13 13:17   ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBCyKtdDBkkECB3I@shredder \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=mlxsw@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).